Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce encrypting DEVICE_INFO #5889

Merged
merged 2 commits into from
Jun 18, 2020
Merged

Enforce encrypting DEVICE_INFO #5889

merged 2 commits into from
Jun 18, 2020

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Jun 18, 2020

Resolves brave/brave-browser#10333

Submitter Checklist:

Test Plan:

  1. Establish sync chain between device A and device B
  2. Go to brave://sync-internals/
  3. We should see DEVICE_INFO listed as encrypted types

Screen Shot 2020-06-17 at 19 16 06

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@darkdh darkdh self-assigned this Jun 18, 2020
@diracdeltas
Copy link
Member

lgtm but i'll defer approval to brianj

@darkdh
Copy link
Member Author

darkdh commented Jun 18, 2020

@darkdh darkdh merged commit 00ebdc0 into master Jun 18, 2020
@darkdh darkdh deleted the encrypted-device-info branch June 18, 2020 19:23
@darkdh darkdh added this to the 1.12.x - Nightly milestone Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Sync v2] Encrypt DEVICE_INFO
3 participants