Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sync v2] Encrypt DEVICE_INFO #10333

Closed
darkdh opened this issue Jun 17, 2020 · 2 comments · Fixed by brave/brave-core#5889
Closed

[Sync v2] Encrypt DEVICE_INFO #10333

darkdh opened this issue Jun 17, 2020 · 2 comments · Fixed by brave/brave-core#5889
Assignees
@darkdh
Labels
feature/sync OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.12.x - Release #1

Comments

@darkdh
Copy link
Member

darkdh commented Jun 17, 2020

In security review:
https://github.com/brave/security/issues/172#issuecomment-645030726
@darkdh darkdh self-assigned this Jun 17, 2020
@darkdh darkdh mentioned this issue Jun 18, 2020
Merged
32 tasks
@darkdh darkdh added this to the 1.12.x - Nightly milestone Jun 18, 2020
@btlechowski
Copy link

btlechowski commented Jul 28, 2020 •
edited by kjozwiak
Loading

Verification passed on

Brave 1.12.102 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
Revision 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#5889

image

Verification passed on


Brave | 1.12.104 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | Windows 10 OS Version 1903 (Build 18362.959)

Verified test plan from brave/brave-core#5889
image

Verification PASSED on macOS 10.15.6 x64 using the following build:

Brave | 1.12.108 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | macOS Version 10.15.6 (Build 19G73)

Ensured that the STR/Cases outlined via brave/brave-core#5889 worked as expected.

DEVICE_INFO A (macOS) DEVICE_INFO B (Windows)
Screen Shot 2020-08-10 at 8 42 44 PM Annotation 2020-08-10 204208

@bbondy bbondy added OS/Android Fixes related to Android browser functionality OS/Desktop labels Aug 7, 2020
@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.12.111 x64 build

  • Verified Device info is listed under encryption types

Verification passed on Samsung Tab A with Android 10 running 1.12.111 x64 build

  • Verified Device info is listed under encryption types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darkdh darkdh

Labels
feature/sync OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
Sync - All platforms
Status: Completed
Milestone
1.12.x - Release #1
Development

Successfully merging a pull request may close this issue.

Enforce encrypting DEVICE_INFO brave/brave-core
6 participants
@bbondy @kjozwiak @darkdh @srirambv @btlechowski @GeetaSarvadnya