Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Native IPFS support in Brave behind a feature flag #5820

Merged
merged 31 commits into from
Sep 3, 2020
Merged

Native IPFS support in Brave behind a feature flag #5820

merged 31 commits into from
Sep 3, 2020

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Jun 11, 2020 •
edited
Loading

Part of brave/brave-browser#10220
Fix brave/brave-browser#11601

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@bbondy bbondy changed the title Ipfs component Native IPFS support in Brave Jun 11, 2020
@bbondy bbondy force-pushed the ipfs-component branch 2 times, most recently from 20bef27 to 42eb328 Compare June 11, 2020 20:54
petemill pushed a commit that referenced this pull request Jul 27, 2020
@emerick
Merge pull request #5820 from brave/android-about-version
eb8a7ba 
Add --android_default_version_name option to build command
petemill pushed a commit that referenced this pull request Jul 28, 2020
@emerick
Merge pull request #5820 from brave/android-about-version
fb16c6b 
Add --android_default_version_name option to build command
@yrliou yrliou force-pushed the ipfs-component branch 2 times, most recently from 9d91b8c to 678d206 Compare August 14, 2020 03:09
@bbondy bbondy marked this pull request as ready for review August 25, 2020 15:24
@bbondy bbondy requested a review from bridiver as a code owner August 25, 2020 15:24
@yrliou yrliou force-pushed the ipfs-component branch 2 times, most recently from ec630ac to 68e8cd4 Compare August 27, 2020 04:35
@bbondy bbondy changed the title Native IPFS support in Brave Native IPFS support in Brave behind a feature flag Aug 31, 2020
yrliou
yrliou reviewed Aug 31, 2020
View reviewed changes
browser/extensions/brave_extension_management.cc Outdated Show resolved Hide resolved
browser/infobars/BUILD.gn Show resolved Hide resolved
browser/infobars/ipfs_infobar_delegate.cc Outdated Show resolved Hide resolved
browser/extensions/api/ipfs_api.h Outdated Show resolved Hide resolved
browser/extensions/api/ipfs_api.cc Outdated Show resolved Hide resolved
browser/extensions/api/ipfs_api.cc Show resolved Hide resolved
browser/extensions/BUILD.gn Outdated Show resolved Hide resolved
browser/infobars/ipfs_infobar_delegate.h Outdated Show resolved Hide resolved
browser/ipfs/content_browser_client_helper.cc Outdated Show resolved Hide resolved
browser/ipfs/content_browser_client_helper.cc Show resolved Hide resolved
bbondy and others added 21 commits September 2, 2020 11:10
@bbondy
Lint fixes
8a2e98e
@yrliou @bbondy
Add IPFS feature flag which is disabled by default
cf14609
@bbondy
Add IPFS WebUI page
aaf5a7a
@yrliou @bbondy
Implement GetConnectedPeers
fbb39dd
@yrliou @bbondy
Fix build error on C85
c85e8ae
@yrliou @bbondy
gn check fixes
d4619b2 
- Move //brave/browser/ipfs target into //brave/browser:browser_process
for including headers under brave/browser.
- Move files that need to access brave/browser or chrome/browser from
  brave/components/ipfs/browser to brave/browser/ipfs.
- Use BrowserContext directly in IpfsServiceFactory
@yrliou @bbondy
Create ipfs::ContentBrowserClientHelper class to wrap static functions
d9563f9
@yrliou @bbondy
Lint fix for IPFSJSONParser
50b5494
@bbondy
Add setting and resolve IPNS too
48d5ba0
@bbondy
Remove logging
9cb0a21
@bbondy
Fix tests for BraveIpfsClientUpdaterTest
a4b04e8
@yrliou @bbondy
Add daemon status & control, addresses config in brave://ipfs page.
c2ce55d
@yrliou @bbondy
Update License format in ipfs_ui component
013872b
@yrliou @bbondy
Launch IPFS daemon when navigating to an IPFS URL if gateway setting …
b35637b 
…is local node
@yrliou @bbondy
Add IpfsServiceBrowserTest and more unit tests
7470850 
This commit also:
  - return error when trying to issue HTTP API requests when daemon is not launched
  - fixes typo in ipfs_utils.cc.
  - add some test utils in IpfsService.
@bbondy
Add IPFS infobar test
91bda06
@bbondy
Add tests for TranslateIPFSURL
2a1efdf
@bbondy
Fix tslint
4638435
@yrliou @bbondy
Use 2020 in new files' license
c05dc6e
@yrliou @bbondy
Remove unnecessary headers and user BrowserContext directly without P…
30ac73e 
…rofile

Also add a few missing deps in the commit.
@bbondy
Add IPNS to autocomplete scheme classifier
749129e
@bbondy
Copy link
Member Author

bbondy commented Sep 2, 2020

Approved reviewing Jocelyn's commits
Can't mark it because I'm the PR author.

@yrliou yrliou added this to the 1.15.x - Nightly milestone Sep 2, 2020
yrliou
yrliou approved these changes Sep 2, 2020
View reviewed changes
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bbondy's commits looks good to me.

bbondy
bbondy commented Sep 2, 2020
View reviewed changes
browser/ipfs/ipfs_service.cc
if (base::EndsWith(origin, "/", base::CompareCase::INSENSITIVE_ASCII)) {
origin.pop_back();
}
request->headers.SetHeader(net::HttpRequestHeaders::kOrigin, origin);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bbondy bbondy merged commit c526953 into master Sep 3, 2020
@bbondy bbondy deleted the ipfs-component branch September 3, 2020 15:28
@bbondy bbondy mentioned this pull request Sep 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrliou yrliou yrliou approved these changes

@bridiver bridiver Awaiting requested review from bridiver bridiver is a code owner

Assignees

@bbondy bbondy

@yrliou yrliou

Labels
None yet
Projects
None yet
Milestone
1.15.x - Release #1
Development

Successfully merging this pull request may close these issues.

Create base implementation of native IPFS behind a feature flag
3 participants
@bbondy @yrliou @drbh