Lint fixes

brave · Jul 16, 2020 · 2ce1045 · 2ce1045
1 parent 6538fe5
commit 2ce1045
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 15 deletions.
diff --git a/browser/extensions/brave_ipfs_client_updater_browsertest.cc b/browser/extensions/brave_ipfs_client_updater_browsertest.cc
@@ -1,4 +1,5 @@
-/* This Source Code Form is subject to the terms of the Mozilla Public
+/* Copyright (c) 2020 The Brave Authors. All rights reserved.
+ * This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this file,
  * You can obtain one at http://mozilla.org/MPL/2.0/. */
 
@@ -15,8 +16,8 @@
 
 using extensions::ExtensionBrowserTest;
 
-const std::string kIpfsClientUpdaterComponentTestId("");
-const std::string kIpfsClientUpdaterComponentTestBase64PublicKey =
+static const char kIpfsClientUpdaterComponentTestId[] "";
+static const char kIpfsClientUpdaterComponentTestBase64PublicKey[] =
     "MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAncFKJWCX6RqCRYOR0t5a"
     "js7HWIVP3Ne272HZs3MqiaNvo9IikbPd4JnUMeQjLhkXTwxg6Up9Tmrgo3M8T91D"
     "dggzpAG4OlhKj3l3N5kZnj/CxQ73YVd41jHAF97lZVoD5VTCGtEelzA5eHI4N4Hd"
@@ -26,7 +27,7 @@ const std::string kIpfsClientUpdaterComponentTestBase64PublicKey =
     "QQIDAQAB";
 
 class BraveIpfsClientUpdaterTest : public ExtensionBrowserTest {
-public:
+ public:
   BraveIpfsClientUpdaterTest() {}
 
   void SetUp() override {

diff --git a/browser/infobars/ipfs_infobar_delegate.h b/browser/infobars/ipfs_infobar_delegate.h
@@ -25,7 +25,7 @@ class IPFSInfoBarDelegate : public ConfirmInfoBarDelegate {
   static void Create(InfoBarService* infobar_service);
 
  private:
-  explicit IPFSInfoBarDelegate();
+  IPFSInfoBarDelegate();
   ~IPFSInfoBarDelegate() override;
 
   infobars::InfoBarDelegate::InfoBarIdentifier GetIdentifier() const override;

diff --git a/browser/ipfs/ipfs_tab_helper.cc b/browser/ipfs/ipfs_tab_helper.cc
@@ -5,6 +5,8 @@
 
 #include "brave/browser/ipfs/ipfs_tab_helper.h"
 
+#include <vector>
+
 #include "brave/browser/brave_browser_process_impl.h"
 #include "brave/browser/infobars/ipfs_infobar_delegate.h"
 #include "chrome/browser/infobars/infobar_service.h"
@@ -13,6 +15,7 @@
 #include "extensions/common/url_pattern.h"
 
 namespace {
+
 bool IsIPFSURL(const GURL& gurl) {
   // Temporary to manually test the infobar
   static std::vector<URLPattern> updater_patterns({
@@ -23,7 +26,8 @@ bool IsIPFSURL(const GURL& gurl) {
       updater_patterns.begin(), updater_patterns.end(),
       [&gurl](URLPattern pattern) { return pattern.MatchesURL(gurl); });
 }
-}
+
+}  // namespace
 
 namespace ipfs {
 

diff --git a/components/ipfs/browser/brave_ipfs_client_updater.h b/components/ipfs/browser/brave_ipfs_client_updater.h
@@ -22,9 +22,10 @@ using brave_component_updater::BraveComponent;
 namespace ipfs {
 
 #if defined(OS_WIN)
-const std::string kIpfsClientComponentName("Brave Ipfs Client Updater (Windows)");
-const std::string kIpfsClientComponentId("lnbclahgobmjphilkalbhebakmblnbij");
-const std::string kIpfsClientComponentBase64PublicKey =
+static const char kIpfsClientComponentName[] =
+    "Brave Ipfs Client Updater (Windows)";
+static const char kIpfsClientComponentId[] = "lnbclahgobmjphilkalbhebakmblnbij";
+static const char kIpfsClientComponentBase64PublicKey[] =
     "MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAuLxVDZm1QIzpMUFMBYym"
     "zriJGzgRYWpun1n9Qgd0240h9zchyZenLnZG0d3XLk38J+tHCoObb+o5sNuSzx43"
     "f0kb3mNk8AkZd/zc8jo9bK56Ep6E1iuWHfjDkl7mCD+o+CNAmDWgdGdaaaRiBIWL"
@@ -33,9 +34,10 @@ const std::string kIpfsClientComponentBase64PublicKey =
     "/CRfYgax5nMumx0x38CmVN53GVB+5TM0mw1bhU52ASysgZjAC0++Kbl1qXeSZuWM"
     "/QIDAQAB";
 #elif defined(OS_MACOSX)
-const std::string kIpfsClientComponentName("Brave Ipfs Client Updater (Mac)");
-const std::string kIpfsClientComponentId("nljcddpbnaianmglkpkneakjaapinabi");
-const std::string kIpfsClientComponentBase64PublicKey =
+static const char kIpfsClientComponentName[] =
+    "Brave Ipfs Client Updater (Mac)";
+static const char kIpfsClientComponentId[] = "nljcddpbnaianmglkpkneakjaapinabi";
+static const char kIpfsClientComponentBase64PublicKey[] =
     "MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAu4gvE67b2T0U0i5awN5Q"
     "8YTyEXkahVAIaDqZaC2GkyjqJxkfThTxNq+MfjRAfeoxdKq95XATHMQPw6bHBCRr"
     "eDokesk0Yf4/2Tm+Sx+5ndrVb44bu0Qe/TM2EprxKvwyMo55pOjoHvnyhExd3E1p"
@@ -44,9 +46,9 @@ const std::string kIpfsClientComponentBase64PublicKey =
     "59uo1UEJYwr+HQ0pvt/gEdns1ccUsGEm9PAMJRptvrGX/fauIMAASvByMRG7XC27"
     "gwIDAQAB";
 #elif defined(OS_LINUX)
-const std::string kIpfsClientComponentName("Brave Ipfs Client Updater (Linux)");
-const std::string kIpfsClientComponentId("oecghfpdmkjlhnfpmmjegjacfimiafjp");
-const std::string kIpfsClientComponentBase64PublicKey =
+static const kIpfsClientComponentName[] = "Brave Ipfs Client Updater (Linux)";
+static const char kIpfsClientComponentId[] = "oecghfpdmkjlhnfpmmjegjacfimiafjp";
+static const kIpfsClientComponentBase64PublicKey[] =
     "MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAuG1akBG8ka37Pdx0F21r"
     "J2efimrZnN8PrBlUBHYZ3sOBFLjzdw7gxpqznbOzNzx4hAAUXdLWPxBZXgOGV+rw"
     "MmCdskXr6dK5yLtJNjWqDHNVxyikQlIKRK3VKO9f6HZBC3SwF/GqLenuFuVxbg1q"