[sync-v2 base] Sync: Show an infobar at startup for sync v1 users #5804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkdh
requested changes
Jun 10, 2020
darkdh
reviewed
Jun 10, 2020
petemill
force-pushed
the
sync-v2-infobar
branch
from
c201f9a to
8054d57
Compare
darkdh
reviewed
Jun 11, 2020
petemill
force-pushed
the
sync-v2-infobar
branch
from
8054d57 to
78254b5
Compare
darkdh
approved these changes
Jun 11, 2020
petemill
force-pushed
the
sync-v2-infobar
branch
from
78254b5 to
509359f
Compare
|
Updated description to include test plan and removed some unused params. Will merge and move test plan to |
The infobar displays a notice that sync v2 must be setup in order to continue syncing. In this infobar, the user can - perform an action to begin sync v2 setup, or; - dismiss the infobar.
petemill
force-pushed
the
sync-v2-infobar
branch
from
509359f to
1467ef7
Compare
This was referenced Jun 22, 2020
Brandon-T
added a commit
that referenced
this pull request
Aug 9, 2022
kjozwiak
added a commit
that referenced
this pull request
Aug 10, 2022
[iOS] - Uplift #5804: Fix Brave-Core Cleanup
kjozwiak
added a commit
that referenced
this pull request
Aug 10, 2022
[iOS] - Uplift #5804: Fix Brave-Core Cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The infobar displays a notice that sync v2 must be setup in order to continue syncing.
In this infobar, the user can
Test Plan
We want a profile with sync v1 enabled, and then open a browser with sync v2 code to test the infobar shows:
Open release version of Brave with a new profile:
[macos]
/Applications/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --user-data-dir=$HOME/Library/Application\ Support/BraveSoftware/5804-sync-v2-infobar-test-1Turn on brave sync flag in chrome://flags
Quit (don't use relaunch button)
Run again release brave with above user data dir command, and enable sync v1 at
brave://syncQuit again
Launch local / nightly / PR build (with sync v2) with same profile via above command (replacing with nightly), or for local build:
yarn start --user_data_dir_name=5804-sync-v2-infobar-test-1Setup sync v2 via
brave://settingsQuit
Relaunch and observe infobar