Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Implement infobar for Android sync v1 users about v1 will be deprecated #10416

Closed
AlexeyBarabash opened this issue Jun 22, 2020 · 2 comments

Comments

@AlexeyBarabash
Copy link
Contributor

AlexeyBarabash commented Jun 22, 2020

Related PR brave/brave-core#5361.

Required to make similar to desktop b-c PR brave/brave-core#5806 to inform Android sync v1 users that sync v1 will be shut down and they need to create a new sync chain with sync v2.

@AlexeyBarabash AlexeyBarabash added the OS/Android Fixes related to Android browser functionality label Jun 22, 2020
@AlexeyBarabash AlexeyBarabash self-assigned this Jun 22, 2020
@AlexeyBarabash AlexeyBarabash changed the title [Android] Implement infobars for Android sync v1 users [Android] Implement infobar for Android sync v1 users Jul 20, 2020
@AlexeyBarabash AlexeyBarabash changed the title [Android] Implement infobar for Android sync v1 users [Android] Implement infobar for Android sync v1 users about v1 will be deprecated Jul 20, 2020
@kjozwiak kjozwiak added this to the Android 1.11.x - Release milestone Jul 23, 2020
@kjozwiak
Copy link
Member

Closing as brave/brave-core#6128 was approved and merged into 1.11.x.

@srirambv
Copy link
Contributor

srirambv commented Jul 24, 2020

Verification passed on OnePlus 6T with Android 10 running 1.11.100 x64 PR build

Sync Enabled

  • Verified upgrading from 1.10.x with sync enabled shows the infobar immediately after launch

  • Verified clicking on Learn more open support page https://support.brave.com/hc/en-us/articles/360021218111-How-do-I-set-up-Sync-

  • Verified dismissing the infobar doesn't show the message again

  • Verified once the infobar is shown closing and reopening the browser doesn't show the message

  • Verified post-upgrade opening a private tab via home screen shows the infobar as well

Sync Disabled

  • Verified upgrading from 1.10.99 without sync enabled doesn't show the infobar

Clean Install

  • Verified clean install of the build, doesn't show any infobar

Verification passed on Samsung Tab A with Android 10 running 1.11.100 x64 PR build

Sync Enabled

  • Verified upgrading from 1.10.x with sync enabled shows the infobar immediately after launch

  • Verified clicking on Learn more open support page https://support.brave.com/hc/en-us/articles/360021218111-How-do-I-set-up-Sync-

  • Verified dismissing the infobar doesn't show the message again

  • Verified once the infobar is shown closing and reopening the browser doesn't show the message

  • Verified post-upgrade opening a private tab via home screen shows the infobar as well

Sync Disabled

  • Verified upgrading from 1.10.99 without sync enabled doesn't show the infobar

Clean Install

  • Verified clean install of the build, doesn't show any infobar

Verification passed on Asus Zenfone (x86) with Android 6.0 running 1.11.102 BraveModernx86.apk

Sync Enabled

  • Verified upgrading from 1.10.99 with sync enabled shows the infobar immediately after launch
    Android-sync-infobar

  • Verified clicking on Learn more open support page https://support.brave.com/hc/en-us/articles/360021218111-How-do-I-set-up-Sync-

  • Verified dismissing the infobar doesn't show the message again

  • Verified once the infobar is shown closing and reopening the browser doesn't show the message

Sync Disabled

  • Verified upgrading from 1.10.99 without sync enabled doesn't show the infobar

Clean Install

  • Verified clean install of the build, doesn't show any infobar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants