Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UI on component update #5724

Merged
merged 1 commit into from
Jun 3, 2020
Merged

Update UI on component update #5724

merged 1 commit into from
Jun 3, 2020

Conversation

deeppandya
Copy link
Contributor

Resolves : brave/brave-browser#10033

Submitter Checklist:

Test Plan:

when the component is ready to with resources for super referral, NTP should be updated with SR image and top sites. please follow the steps on the issue.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@deeppandya deeppandya added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jun 3, 2020
@deeppandya deeppandya added this to the 1.10.x - Beta milestone Jun 3, 2020
@deeppandya deeppandya self-assigned this Jun 3, 2020
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@deeppandya deeppandya merged commit f862599 into master Jun 3, 2020
@deeppandya deeppandya deleted the SR_components_update_dp branch June 3, 2020 17:30
brave-builds pushed a commit that referenced this pull request Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] First NTP doesn't load SR images even when component is ready
3 participants