Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] First NTP doesn't load SR images even when component is ready #10033

Closed
srirambv opened this issue Jun 1, 2020 · 2 comments · Fixed by brave/brave-core#5724
Closed

Comments

@srirambv
Copy link
Contributor

srirambv commented Jun 1, 2020

Description

First NTP doesn't load SR images even when component is ready

Steps to reproduce

  1. Install SR build
  2. Open the browser and wait for the component to be downloaded
  3. First NTP gets the custom assets tiles but doesn't download the image

Actual result

First NTP doesn't load SR images even when the component is ready
Recording: https://bravesoftware.slack.com/archives/C0816QH3R/p1590990198121500

Expected result

Should be similar to iOS and load all current tabs with custom assets when the component is ready

Issue reproduces how often

Easy

Issue happens on

  • Current Play Store version? NA
  • Beta build? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device (Phone, Tablet, Phablet): Phone
  • Android version: 10

Brave version

1.9.77

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

@srirambv srirambv added bug feature/new-tab QA/Yes release-notes/exclude OS/Android Fixes related to Android browser functionality labels Jun 1, 2020
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 1, 2020

Reproduced in Gionee 5.1 running BraveModernarm.1.9.77.apk

@btlechowski
Copy link

btlechowski commented Jun 17, 2020

Verification passed on BraveModernarm v1.10.92 on Samsung Galaxy Tab S5e (Android 9.0)

Verified test plan from the description.
Verified that if regular ntp images are not ready, a place holder is shown
Verified regular ntp images replace place holder when ready
Verified sr ntp images replace regular ntp images when ready

Verification passed on Samsung Galaxy Je version 5.1.1 running BraveModernarm 1.10.92.apk

  • Ensured that SR image is shown in the first NTP when the component is ready
  • Ensured that SR images are shown in all NTP's
  • Ensured that Brave Default bg images are shown when Brave Default theme is selected in Appearances
  • Ensured that SR images are shown when Brave Default theme is turned off in Appearances
  • Ensured that SR images are shown in all NTP's in both Light/Dark mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants