Allows send/save cookies for access token route [Binance] (uplift to 1.10.x) #5650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbondy
changed the title
srirambv
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uplift of #5607
To avoid merge conflicts, this also had to be pulled in: #5543
Fixes brave/brave-browser#9863
Fixes brave/brave-browser#9377
Why is this being requested for uplift?
If a user does the oauth flow on the Binance widget, but creates a new account, they will not be logged in. This looks like a bug to the user for new users. This regressed with the 1.9.x release because of the ref code change we pulled in.
If approved, please ensure that before merging:
After you merge: