Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset conversion goes through once network is back up without user interaction #9377

Closed
srirambv opened this issue Apr 22, 2020 · 2 comments · Fixed by brave/brave-core#5543

Comments

@srirambv
Copy link
Contributor

Description

Asset conversion goes through once network is back up without user interaction

Steps to Reproduce

  1. Connect widget with Binance account
  2. Select an asset to convert
  3. Click on Preview conversion
  4. Disconnect network while the preview conversion countdown is shown
  5. Click a couple times while the preview conversion countdown is being shown
  6. Widget throws Unable to convert message and shows retry button
  7. Bring the network back up
  8. Conversion goes through without user interaction even when retry message is shown

Actual result:

Conversion goes through without user interaction

Expected result:

Conversion should not go through without user interaction

Reproduces how often:

Intermittent issue happened once but not able to reproduce it

Brave version (brave://version info)

Brave 1.9.37 Chromium: 81.0.4044.113 (Official Build) nightly (64-bit)
Revision cf9d66371ea608e227eed56ccba3abc2701bd23d-refs/branch-heads/4044@{#936}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the dev channel? NA
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

@srirambv srirambv added needs-investigation A bug not 100% confirmed/fixed intermittent-issue QA/Yes feature/web3/wallet Integrating Ethereum+ wallet support feature/widgets labels Apr 22, 2020
@bbondy bbondy added the priority/P4 Planned work. We expect to get to it "soon". label Apr 24, 2020
@bbondy bbondy added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels May 8, 2020
@bbondy bbondy self-assigned this May 8, 2020
@srirambv srirambv removed the feature/web3/wallet Integrating Ethereum+ wallet support label May 14, 2020
@bbondy bbondy added this to the 1.11.x - Nightly milestone May 15, 2020
@srirambv
Copy link
Contributor Author

Moving to 1.9.x as brave/brave-core#5651 is uplifted

@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.9.76 Chromium: 81.0.4044.138 (Official Build) (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{# 999}
OS Linux
  • Verified Unable to convert message is shown when network is not available
  • Verified asset conversion only happens when network is active

Verification passed on

Brave 1.9.76 Chromium: 81.0.4044.138 (Official Build) (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{# 999}
OS Windows 10 OS Version 1809 (Build 17763.379)
  • Verified Unable to convert message is shown when network is not available
  • Verified asset conversion only happens when network is active

Verification passed on

Brave 1.9.76 Chromium: 81.0.4044.138 (Official Build) (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{# 999}
OS macOS Version 10.15.4 (Build 19E287)
  • Verified Unable to convert message is shown when network is not available
  • Verified asset conversion only happens when network is active

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants