Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Brave Ads crash on iOS for ads with an invalid target URL #5614

Merged
merged 1 commit into from
May 21, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented May 21, 2020

Resolves brave/brave-browser#9873

Refs brave/brave-ios#2564

Submitter Checklist:

Test Plan:

See brave/brave-browser#9873

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@tmancey tmancey self-assigned this May 21, 2020
@kylehickinson kylehickinson added CI/skip-android Do not run CI builds for Android CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels May 21, 2020
@tmancey tmancey force-pushed the issues/9873 branch 2 times, most recently from 5d966bf to e9ef2f4 Compare May 21, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 feature/ads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Desktop] Brave Ads crashes on iOS for ads with an invalid target URL
2 participants