Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Brave Ads crashes on iOS for ads with an invalid target URL #9873

Closed
tmancey opened this issue May 21, 2020 · 1 comment · Fixed by brave/brave-core#5614
Closed

Comments

@tmancey
Copy link
Contributor

tmancey commented May 21, 2020

Description

Brave Ads crashes on iOS for ads with an invalid target URL

Steps to Reproduce

  1. Add an ad with an invalid target url to the catalog
  2. Click an ad

Actual result:

Application crashes

Expected result:

Application should not crash

Reproduces how often:

No steps to reproduce

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@tmancey tmancey added bug crash priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include feature/ads labels May 21, 2020
@tmancey tmancey self-assigned this May 21, 2020
@tmancey tmancey changed the title Fix Brave Ads crash on iOS for ads with an invalid target URL Brave Ads crashes on iOS for ads with an invalid target URL May 21, 2020
@tmancey tmancey added this to the 1.11.x - Nightly milestone May 21, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Jul 1, 2020

Verified passed with

Brave | 1.11.84 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
-- | --
Revision | 8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS | macOS Version 10.14.6 (Build 18G3020)
  • Verified STR from description
  • Used Charles Proxy to rewrite staging catalog so that an ad had an invalid targetURL. When I clicked on the ad, confirmed that Brave did not crash.

Verification passed on

Brave 1.11.89 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
Revision 8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS Ubuntu 18.04 LTS

Verified test plan from the description
Used Charles Proxy to rewrite staging catalog so that an ad had an invalid targetURL. When I clicked on the ad, confirmed that Brave did not crash.


Verification passed on


Brave | 1.11.90 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
-- | --
Revision | 8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS | Windows 10 OS Version 1903 (Build 18362.900)


Verified test plan from the description
Used Charles Proxy to rewrite staging catalog so that an ad had an invalid targetURL. When I clicked on the ad, confirmed that Brave did not crash.

@rebron rebron changed the title Brave Ads crashes on iOS for ads with an invalid target URL [Desktop] Brave Ads crashes on iOS for ads with an invalid target URL Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants