Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update custom homepage top site download link (uplift to 1.9.x) #5544

Merged
merged 1 commit into from
May 29, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented May 13, 2020

Uplift of #5509
Fixes brave/brave-browser#9714

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this May 13, 2020
@brave-builds brave-builds added this to the 1.9.x - Beta milestone May 13, 2020
@kjozwiak
Copy link
Member

Looks like test-browser failed on macOS as per https://ci.brave.com/job/pr-brave-browser-pr5509_fix_for_download_link_dp_1.9.x/1/execution/node/566/log/.

19:04:14  [  FAILED  ] BraveRewardsBrowserTest.NotVerifiedWallet, where TypeParam =  and GetParam() =  (6595 ms)
19:04:14  [539/539] BraveRewardsBrowserTest.NotVerifiedWallet (6875 ms)
19:04:14  1 test failed:
19:04:14      BraveRewardsBrowserTest.NotVerifiedWallet (../../brave/components/brave_rewards/browser/rewards_service_browsertest.cc:2331)

However, this is a known issue which will be fixed via brave/brave-browser#9339 and doesn't block uplift.

@bsclifton bsclifton requested review from a team and removed request for bbondy, kjozwiak, bsclifton, rebron and srirambv May 17, 2020 08:56
Copy link
Contributor

@srirambv srirambv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 1.9.x approved after deliberating with @brave/uplift-approvers .

@srirambv srirambv merged commit 1f54598 into 1.9.x May 29, 2020
@srirambv srirambv deleted the pr5509_fix_for_download_link_dp_1.9.x branch May 29, 2020 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants