Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Fix download link for top sites #9714

Closed
deeppandya opened this issue May 11, 2020 · 2 comments · Fixed by brave/brave-core#5509
Closed

[Android] Fix download link for top sites #9714

deeppandya opened this issue May 11, 2020 · 2 comments · Fixed by brave/brave-core#5509
Assignees
@deeppandya
Labels
ARM Android ARM related issues OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Milestone
Android 1.9.x Rel...

Comments

@deeppandya
Copy link

deeppandya commented May 11, 2020 •
edited
Loading

Description

Download link for custom homepage top sites are missing the right permission.

Steps to reproduce

  1. Download the app with Ref code on the device with > android 6
  2. try to download link from the top sites

Actual result

Download fails

Expected result

it should download the link without any crash.

Issue reproduces how often

Issue happens on

  • Current Play Store version?
  • Beta build?

Device details

  • Install type (ARM, x86):
  • Device (Phone, Tablet, Phablet):
  • Android version:

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information
@deeppandya deeppandya added the OS/Android Fixes related to Android browser functionality label May 11, 2020
@deeppandya deeppandya added this to the Android 1.8.x HF 1 Release milestone May 11, 2020
@deeppandya deeppandya self-assigned this May 11, 2020
@deeppandya deeppandya changed the title [Android] [Android] Fix download link for top sites May 11, 2020
@deeppandya deeppandya mentioned this issue May 11, 2020
Merged
31 tasks
@SergeyZhukovsky SergeyZhukovsky removed this from the Android 1.8.x HF 1 Release milestone May 12, 2020
@brave-builds brave-builds mentioned this issue May 17, 2020
Merged
4 tasks
@LaurenWags LaurenWags added the ARM Android ARM related issues label May 29, 2020
@LaurenWags
Copy link
Member

Labelled as ARM since x86 devices do not have super referral.

@srirambv srirambv added the QA/Yes label Jun 1, 2020
@srirambv
Copy link
Contributor

srirambv commented Jun 1, 2020 •
edited by btlechowski
Loading

Verification passed on OnePlus 6T with Android 10 running 1.9.77 x64 stable build

  • Verified downloading top tile asks for storage access

Verification passed on Samsung Tab A with Android 9 running 1.9.77 x64 stable build

  • Verified downloading top tile asks for storage access

Verification passed on Gionee 5.1.1 running BraveModernarm 1.9.77.apk

  • Verified downloading top tiles did not ask for storage access in low-end devices. link stored in the default download location. (As per the issue description this is expected, fix is only for android version greater than 6)

Verification passed on BraveModernarm v1.9.77 on Samsung Galaxy Tab S5e (Android 9.0)

  • Verified downloading top tile asks for storage access

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
ARM Android ARM related issues OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Projects
None yet
Milestone
Android 1.9.x Release
Development

Successfully merging a pull request may close this issue.

Update custom homepage top site download link brave/brave-core
4 participants
@deeppandya @SergeyZhukovsky @srirambv @LaurenWags