Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds pagination to publisher list (uplift to 1.8.x) #5472

Merged
merged 1 commit into from
May 11, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented May 6, 2020

Uplift of #5458
Fixes brave/brave-browser#9607

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@NejcZdovc NejcZdovc requested a review from a team May 6, 2020 13:13
@NejcZdovc NejcZdovc requested a review from gdregalo as a code owner May 6, 2020 13:13
@NejcZdovc NejcZdovc self-assigned this May 6, 2020
@NejcZdovc NejcZdovc removed the request for review from gdregalo May 7, 2020 07:04
@kjozwiak
Copy link
Member

@NejcZdovc mind taking a look? Looks like all the platforms are failing init.

@kjozwiak
Copy link
Member

Looks like test-browser failed on Linux as per https://ci.brave.com/job/pr-brave-browser-pub-list-pagination-1.8/4/execution/node/420/log/. However, this a known intermittent issue and will be addressed via brave/brave-browser#5397 and not blocking uplift.

03:29:38  [  FAILED  ] BraveRewardsBrowserTest.ProcessPendingContributions, where TypeParam =  and GetParam() =  (37759 ms)
03:29:38  [539/540] BraveRewardsBrowserTest.ProcessPendingContributions (38025 ms)
03:29:44  [540/540] BraveRewardsBrowserTest.SplitProcessorAutoContribution (5241 ms)
03:29:44  1 test failed:
03:29:44      BraveRewardsBrowserTest.ProcessPendingContributions (../../brave/components/brave_rewards/browser/rewards_service_browsertest.cc:2186)

Looks like test-install failed on macOS as per https://ci.brave.com/job/pr-brave-browser-pub-list-pagination-1.8/4/execution/node/549/log/. However, this is a known intermittent issue as per brave/brave-browser#9480 and not blocking uplift.

Travis also failed due to TEST_SUITE=test-security because of the yargs-parser npm package which is a known issue and not blocking uplift.

@kjozwiak kjozwiak added this to the 1.8.x - HF 3 Placeholder milestone May 11, 2020
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.8.x approved after deliberating with @brave/uplift-approvers. QA verified the PR on Nightly as per #5458 (comment). Ensured that the issue was moved into the appropriate milestone.

@kjozwiak kjozwiak merged commit 6c8a81d into 1.8.x May 11, 2020
@kjozwiak kjozwiak deleted the pub-list-pagination-1.8 branch May 11, 2020 16:54
bsclifton pushed a commit that referenced this pull request May 12, 2020
Adds pagination to publisher list (uplift to 1.8.x)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants