Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Implement pagination for publisher list #9724

Closed
kjozwiak opened this issue May 11, 2020 · 1 comment
Closed

[Android] Implement pagination for publisher list #9724

kjozwiak opened this issue May 11, 2020 · 1 comment

Comments

@kjozwiak
Copy link
Member

Created duplicate of #9607 as this was placed in 1.9.x for desktop. If there's another HF for desktop, #9607 will be moved into that milestone. However, this will most likely go out first in the 1.18.x HF1 on Android that will include the CR bump.

Test plan

See brave/brave-core#5458

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 13, 2020

Verification passed on Samsung Galaxy j3 version 5.1.1 running BraveModernarm.apk 1.8.112

  • Verified the test plan from Adds pagination to publisher list brave-core#5458 (comment)
  • Verified that able to see the following verified publisher types on Android: regular sites, youtube channels, twitter, vimeo, and github.
  • Verified both Production and Staging environments (below SS are from both env's)
    Screenshot_2020-05-13-11-14-33
    Screenshot_2020-05-13-11-15-30
    Screenshot_2020-05-13-11-16-29
    Screenshot_2020-05-13-11-34-34
    Screenshot_2020-05-13-10-46-52
    Screenshot_2020-05-13-10-50-46
    Screenshot_2020-05-13-10-52-54
    Screenshot_2020-05-13-10-54-29
    Screenshot_2020-05-13-10-58-44
    Screenshot_2020-05-13-11-01-22
  • Verified publisher list download in logs
    Production:
[ REQUEST ]
    > url: https://publishers-distro.basicattentiontoken.org/api/v3/public/channels?page=4
    > method: UrlMethod::GET
    > content: 
    > contentType: 
    > header: Accept-Encoding: gzip
[ END REQUEST ]

[ RESPONSE - OnDownload ]
    > time: 1589355982
    > result: Success
    > http code: 200
    > response: Publisher list
    > headers accept-ranges: bytes
    > headers access-control-allow-headers: Origin, X-Requested-With, Content-Type, Accept, Authorization
    > headers access-control-allow-methods: GET
    > headers access-control-allow-origin: https://rewards.bravesoftware.com
    > headers access-control-request-method: GET
    > headers age: 692
    > headers cache-control: max-age=3600, public
    > headers content-encoding: gzip
    > headers content-length: 3724636
    > headers content-type: application/json; charset=utf-8
    > headers date: Wed, 13 May 2020 07:46:24 GMT
    > headers etag: W/"a7419ebfe1828654b786776e7964acd5"
    > headers server: Cowboy
    > headers status: 200
    > headers strict-transport-security: max-age=31536000; includeSubDomains
    > headers vary: Accept-Encoding
    > headers via: 1.1 varnish
    > headers x-cache: HIT
    > headers x-cache-hits: 7
    > headers x-frame-options: deny
    > headers x-request-id: 5e6d567c-cfdc-4755-b64d-9d15d36e161a
    > headers x-runtime: 2.284509
    > headers x-served-by: cache-bom18224-BOM
 [ END RESPONSE ]

Verification passed on BraveModernarm v1.8.112 on Samsung Galaxy Tab S5e (Android 9.0)

  • Verified the test plan from Adds pagination to publisher list brave-core#5458 (comment)
  • Verified that able to see the following verified publisher types on Android: regular sites, youtube channels, twitter, vimeo, and github.
  • Verified both Production and Staging environments (below SS are from both env's)
    Screenshot_20200513-192748_Brave
    Screenshot_20200513-193412_Brave
    Screenshot_20200513-194319_Brave
    Screenshot_20200513-194619_Brave
    Screenshot_20200513-195029_Brave
    Screenshot_20200513-195144_Brave
    Screenshot_20200513-195325_Brave
    Screenshot_20200513-195628_Brave
2020-05-14 17:33:48.416 12807-12848/? V/chromium: [VERBOSE1:ledger_impl.cc(468)] 
    [ REQUEST ]
    > url: https://publishers-distro.basicattentiontoken.org/api/v3/public/channels?page=1
    > method: UrlMethod::GET
    > content: 
    > contentType: 
    > header: Accept-Encoding: gzip
    [ END REQUEST ]
2020-05-14 17:33:53.738 12807-12848/? V/chromium: [VERBOSE1:ledger_impl.cc(468)] 
    [ REQUEST ]
    > url: https://publishers-distro.basicattentiontoken.org/api/v3/public/channels?page=2
    > method: UrlMethod::GET
    > content: 
    > contentType: 
    > header: Accept-Encoding: gzip
    [ END REQUEST ]
2020-05-14 17:34:01.639 12807-12848/? V/chromium: [VERBOSE1:ledger_impl.cc(468)] 
    [ REQUEST ]
    > url: https://publishers-distro.basicattentiontoken.org/api/v3/public/channels?page=3
    > method: UrlMethod::GET
    > content: 
    > contentType: 
    > header: Accept-Encoding: gzip
    [ END REQUEST ]
2020-05-14 17:33:49.081 12807-12848/? V/chromium: [VERBOSE1:ledger_impl.cc(965)] 
    [ RESPONSE - OnDownload ]
    > time: 1589470429
    > result: Success
    > http code: 200
    > response: Publisher list
    > headers accept-ranges: bytes
    > headers access-control-allow-headers: Origin, X-Requested-With, Content-Type, Accept, Authorization
    > headers access-control-allow-methods: GET
    > headers access-control-allow-origin: https://rewards.bravesoftware.com
    > headers access-control-request-method: GET
    > headers age: 738
    > headers cache-control: max-age=3600, public
    > headers content-encoding: gzip
    > headers content-length: 3725548
    > headers content-type: application/json; charset=utf-8
    > headers date: Thu, 14 May 2020 15:33:47 GMT
    > headers etag: W/"f1d80dac7fa1e2407a90023a2dd9a69a"
    > headers server: Cowboy
    > headers status: 200
    > headers strict-transport-security: max-age=31536000; includeSubDomains
    > headers vary: Accept-Encoding
    > headers via: 1.1 varnish
    > headers x-cache: HIT
    > headers x-cache-hits: 5
    > headers x-frame-options: deny
    > headers x-request-id: 48c0bd2c-2f47-40ff-8ceb-9975ae9ebcb3
    > headers x-runtime: 0.895788
    > headers x-served-by: cache-hhn4068-HHN
    [ END RESPONSE ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants