Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom tipping banners not displayed #7766

Closed
LaurenWags opened this issue Mar 6, 2019 · 4 comments
Closed

custom tipping banners not displayed #7766

LaurenWags opened this issue Mar 6, 2019 · 4 comments
Labels
ARM Android ARM related issues feature/rewards OS/Android Fixes related to Android browser functionality

Comments

@LaurenWags
Copy link
Member

Description

When I go to a site that is verified on staging with a custom tip banner, the custom banner is not displayed when I go to tip the site.

Steps to Reproduce

  1. Navigate to a site like kjozwiakstaging.github.io using 1.0.85.
  2. Open panel, you can see that the site is verified on the panel.
  3. Tap on Send a Tip

Actual result:

Custom tip banner is not displayed:
tipbanner-notcustom

Expected result:

Custom tip banner should be displayed if it exists for site. This is the banner that is displayed on desktop for same site:
screen shot 2019-03-06 at 5 08 46 pm

Issue reproduces how often:

easily

Issue happens on:

  • Current Playstore version? no
  • Beta build? Rewards Beta

Device Details:

  • Install Type(ARM, x86): all
  • Device(Phone, Tablet, Phablet): all
  • Android Version: all

Brave version:

1.0.85 (BR_5)

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

@LaurenWags
Copy link
Member Author

cc @anthonypkeane for milestone guidance

@GeetaSarvadnya
Copy link

Custom tipping amounts are also not shown correctly in Android. Reproduced in 1.17.x

Desktop:
image

Android:
image

@NejcZdovc
Copy link
Contributor

@GeetaSarvadnya android never had custom banners

@Miyayes
Copy link
Collaborator

Miyayes commented Jul 21, 2021

Closing in favor of fresher #17070.

@Miyayes Miyayes closed this as completed Jul 21, 2021
@Miyayes Miyayes closed this as not planned Won't fix, can't repro, duplicate, stale Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARM Android ARM related issues feature/rewards OS/Android Fixes related to Android browser functionality
Projects
None yet
Development

No branches or pull requests

7 participants