Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated installreferrer lib (uplift to 1.8.x) #5385

Merged
merged 1 commit into from
May 4, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Apr 27, 2020

Uplift of #5365
Fixes brave/brave-browser#9454

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Apr 27, 2020
@brave-builds brave-builds added this to the 1.8.x - Release milestone Apr 27, 2020
@bsclifton bsclifton requested review from a team and removed request for bbondy, kjozwiak, bsclifton, rebron and srirambv April 28, 2020 16:44
@kjozwiak
Copy link
Member

kjozwiak commented May 1, 2020

Restarting as the b-b never started and ended up timing out.

@kjozwiak
Copy link
Member

kjozwiak commented May 2, 2020

Looks like macOS failed test-install as per https://ci.brave.com/job/brave-browser-build-pr/job/pr5365_android_update_installreferrer_1.8.x/1/execution/node/635/log/

FailedConsole Output
18:33:32  ++ diskutil list
18:33:32  ++ grep 'Brave Browser'
18:33:32  ++ awk '-FMB   ' '{ print $2 }'
18:33:32  + VOLUME=disk2s2
18:33:32  + arr=($VOLUME)
18:33:32  + declare -a arr
18:33:32  + for i in '"${arr[@]}"'
18:33:32  + diskutil unmountDisk force disk2s2
18:33:32  Forced unmount of all volumes on disk2 was successful
18:33:32  + diskutil eject disk2s2
18:33:32  Disk disk2s2 ejected
18:33:32  + '[' -z ']'
18:33:32  + BROWSER='Brave Browser Nightly'
18:33:32  + BUILD_TYPE=Release
18:33:32  + SKIP_SIGNING=true
18:33:32  + OUT_DIR=/Users/jenkins/jenkins/workspace/oid_update_installreferrer_1.8.x/src/out/Release
18:33:32  + '[' true = true ']'
18:33:32  + hdiutil attach -nobrowse '/Users/jenkins/jenkins/workspace/oid_update_installreferrer_1.8.x/src/out/Release/unsigned_dmg/Brave Browser Nightly.dmg'
18:33:32  Checksumming Driver Descriptor Map (DDM : 0)…
18:33:32       Driver Descriptor Map (DDM : 0): verified   CRC32 $C9B78FC7
18:33:32  Checksumming Apple (Apple_partition_map : 1)…
18:33:32       Apple (Apple_partition_map : 1): verified   CRC32 $6EE778CC
18:33:32  Checksumming DiscRecording 9.0.3d5 (Apple_HFS : 2)…
18:33:41  DiscRecording 9.0.3d5 (Apple_HFS : 2: verified   CRC32 $0FB6BAAC
18:33:41  verified   CRC32 $9BC8E880
18:33:42  /dev/disk2          	Apple_partition_scheme         	
18:33:42  /dev/disk2s1        	Apple_partition_map            	
18:33:42  /dev/disk2s2        	Apple_HFS                      	/Volumes/Brave Browser Nightly
18:33:42  + sleep 10
18:33:52  + open '/Volumes/Brave Browser Nightly/Brave Browser Nightly.app'
18:33:52  LSOpenURLsWithRole() failed with error -600 for the file /Volumes/Brave Browser Nightly/Brave Browser Nightly.app.

This is a known issue which doesn't block uplift but will be resolved by brave/brave-browser#9480.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.8.x approved after deliberating with @brave/uplift-approvers. As discussed previously with @SergeyZhukovsky, this can't be QA'd as it needs to be on the GPS. However, we don't have have a Nightly channel in GPS so we'll need to check this one it lands in Beta. Moved the associated issue into the appropriate milestone.

@kjozwiak kjozwiak merged commit eac4020 into 1.8.x May 4, 2020
@kjozwiak kjozwiak deleted the pr5365_android_update_installreferrer_1.8.x branch May 4, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants