Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated installreferrer lib (uplift to 1.9.x) #5384

Merged
merged 1 commit into from
May 4, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Apr 27, 2020

Uplift of #5365
Fixes brave/brave-browser#9454

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Apr 27, 2020
@brave-builds brave-builds added this to the 1.9.x - Beta milestone Apr 27, 2020
@bsclifton bsclifton requested review from a team and removed request for bbondy, kjozwiak, bsclifton, rebron and srirambv April 28, 2020 16:48
@kjozwiak
Copy link
Member

kjozwiak commented May 1, 2020

Restarting as the b-b never started and ended up timing out.

@kjozwiak
Copy link
Member

kjozwiak commented May 2, 2020

Looks like macOS failed due to test-browser failing as per https://ci.brave.com/job/brave-browser-build-pr/job/pr5365_android_update_installreferrer_1.9.x/1/execution/node/610/log/.

18:03:12  [  FAILED  ] BraveRewardsBrowserTest.NotVerifiedWallet, where TypeParam =  and GetParam() =  (6668 ms)
18:03:12  [539/539] BraveRewardsBrowserTest.NotVerifiedWallet (6865 ms)
18:03:12  1 test failed:
18:03:12      BraveRewardsBrowserTest.NotVerifiedWallet (../../brave/components/brave_rewards/browser/rewards_service_browsertest.cc:2326)

This is a known issue which will be resolved by brave/brave-browser#9339 and doesn't block uplift.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.9.x approved after deliberating with @brave/uplift-approvers. As discussed previously with @SergeyZhukovsky, this can't be QA'd as it needs to be on the GPS. However, we don't have have a Nightly channel in GPS so we'll need to check this one it lands in Beta. Moved the associated issue into the appropriate milestone.

@kjozwiak kjozwiak merged commit 0975204 into 1.9.x May 4, 2020
@kjozwiak kjozwiak deleted the pr5365_android_update_installreferrer_1.9.x branch May 4, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants