Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update focal points for SI (Uplift to 1.7.x) #5360

Merged
merged 1 commit into from
Apr 26, 2020
Merged

Update focal points for SI (Uplift to 1.7.x) #5360

merged 1 commit into from
Apr 26, 2020

Conversation

deeppandya
Copy link
Contributor

uplift of #5349

@deeppandya deeppandya requested a review from kjozwiak April 24, 2020 15:33
@deeppandya deeppandya self-assigned this Apr 24, 2020
@deeppandya deeppandya added the CI/skip-ios Do not run CI builds for iOS label Apr 24, 2020
@kjozwiak kjozwiak added this to the Android 1.7.x Release milestone Apr 24, 2020
@kjozwiak
Copy link
Member

QA verified #5349 on Nightly as per #5349 (comment).

kjozwiak
kjozwiak approved these changes Apr 26, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.7.x approved after deliberating with @brave/uplift-approvers. Please make sure that all the correct labels are being used and the associated issue is moved into the correct milsetone.

@kjozwiak kjozwiak merged commit f4b9f6a into 1.7.x Apr 26, 2020
@kjozwiak kjozwiak deleted the hotfix_for_SI_centerpoint_1.7.x branch April 26, 2020 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@petemill petemill Awaiting requested review from petemill petemill is a code owner

@simonhong simonhong Awaiting requested review from simonhong simonhong is a code owner

Assignees

@deeppandya deeppandya

Labels
CI/skip-ios Do not run CI builds for iOS
Projects
None yet
Milestone
Android 1.7.x Release
Development

Successfully merging this pull request may close these issues.
2 participants
@deeppandya @kjozwiak