Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update focal points for SI #5349

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Update focal points for SI #5349

merged 1 commit into from
Apr 23, 2020

Conversation

deeppandya
Copy link
Contributor

Resolves : brave/brave-browser#9426

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@deeppandya deeppandya added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Apr 23, 2020
@deeppandya deeppandya self-assigned this Apr 23, 2020
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@kjozwiak
Copy link
Member

Verification PASSED on Samsung S10+ running Android 10 using:

Brave - Nightly 1.10.9 CR: 81.0.4044.122

Android

Broken (Previous) Fixed
Screenshot_20200424-175103_Brave Screenshot_20200424-175107_Brave - Nightly
Screenshot_20200424-175450_Brave Screenshot_20200424-175453_Brave - Nightly
Screenshot_20200424-175640_Brave Screenshot_20200424-175645_Brave - Nightly

Just for comparison, the new FIXED images look the same as iOS now. Example:

IMG_0061

IMG_0060

IMG_0059

@kjozwiak kjozwiak added this to the 1.10.x - Nightly milestone Apr 24, 2020
@bradleyrichter
Copy link
Contributor

perfect. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Use defined center for Sponsored images
4 participants