Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest l10n from Transifex. #5350

Merged
merged 3 commits into from
Apr 25, 2020
Merged

Latest l10n from Transifex. #5350

merged 3 commits into from
Apr 25, 2020

Conversation

mkarolin
Copy link
Collaborator

Fixes brave/brave-browser#9161

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@mkarolin mkarolin added this to the 1.10.x - Nightly milestone Apr 23, 2020
@mkarolin mkarolin requested review from bbondy and bsclifton April 23, 2020 20:44
@mkarolin mkarolin requested a review from NejcZdovc as a code owner April 23, 2020 20:44
@mkarolin mkarolin self-assigned this Apr 23, 2020
@bsclifton bsclifton added the CI/skip Do not run CI builds (except noplatform) label Apr 24, 2020
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Fixes get_fingerprint_for_xtb in situations when message_tag.text ends
up being None.
@mkarolin mkarolin added CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 and removed CI/skip Do not run CI builds (except noplatform) labels Apr 24, 2020
@mkarolin mkarolin merged commit e03f4fd into master Apr 25, 2020
@mkarolin mkarolin deleted the maxk-c81-l10n branch April 25, 2020 00:48
mkarolin added a commit that referenced this pull request Apr 25, 2020
mkarolin added a commit that referenced this pull request Apr 25, 2020
mkarolin added a commit that referenced this pull request Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customize text on NTP is not translated
3 participants