Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize text on NTP is not translated #9161

Closed
btlechowski opened this issue Apr 13, 2020 · 5 comments · Fixed by brave/brave-core#5350
Closed

Customize text on NTP is not translated #9161

btlechowski opened this issue Apr 13, 2020 · 5 comments · Fixed by brave/brave-core#5350

Comments

@btlechowski
Copy link

btlechowski commented Apr 13, 2020

Follow up to #4930

Steps to Reproduce

  1. Openn NTP in Polish locale

Actual result:

Customize is not translated
The tooltip is not translated

image

Expected result:

Customize is translated
The tooltip is translated

Reproduces how often:

100% repro rate

Brave version (brave://version info)

Reproduced on

Brave 1.8.72 Chromium: 81.0.4044.92 (Official Build) dev (64-bit)
Revision e98e6f21168a55e7ba57202f56323911cd9d31d1-refs/branch-heads/4044@{#883}
OS Ubuntu 18.04 LTS

Reproduced on

Brave 1.9.18 Chromium: 81.0.4044.92 (Official Build) nightly (64-bit)
Revision 32921c79b6f01a0fb2deef0e1d45b42f96581051-refs/branch-heads/4044@{#883}
OS Ubuntu 18.04 LTS

cc @mkarolin @rebron @brave/legacy_qa @cezaraugusto

@elemanhillary-zz
Copy link

i would like to be assigned this

@mkarolin
Copy link
Contributor

The string was added via brave/brave-core#5103 after we did the latest l10n round (brave/brave-core#5089). If it's important to have this localized sooner than the next round (for 1.9.x) then pls let me know.

@elemanhillary-zz
Copy link

@mkarolin yes it is.

@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Apr 14, 2020
mkarolin added a commit to brave/brave-core that referenced this issue Apr 24, 2020
@mkarolin mkarolin added this to the 1.10.x - Nightly milestone Apr 25, 2020
@bsclifton
Copy link
Member

@elemanhillary you can sign up for our Transifex project here:
https://www.transifex.com/brave/brave/

This is where we pull the translations from 😄 Anything other than English on GitHub gets destroyed and replaced with the contents of Transifex when we pull latest

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 27, 2020

Verification passed on

Brave 1.8.84 Chromium: 81.0.4044.122 (Official Build) (64-bit)
Revision 44f4233f08910d83b146130c1938256a2e05b136-refs/branch-heads/4044@{#963}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified the test plan from the description
    image

Verified passed with

Brave 1.8.84 Chromium: 81.0.4044.122 (Official Build) (64-bit)
Revision 44f4233f08910d83b146130c1938256a2e05b136-refs/branch-heads/4044@{#963}
OS macOS Wersja 10.14.6 (kompilacja 18G3020)
  • Verified STR from description
    Polish

Verification passed on

Brave 1.8.85 Chromium: 81.0.4044.122 (Official Build) (64-bit)
Revision 44f4233f08910d83b146130c1938256a2e05b136-refs/branch-heads/4044@{#963}
OS Ubuntu 18.04 LTS

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants