Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade patches from Chromium 81.0.4044.83 to Chromium 81.0.4044.92 (uplift to 1.8.x) #5190

Merged
merged 1 commit into from
Apr 9, 2020
Merged

Upgrade patches from Chromium 81.0.4044.83 to Chromium 81.0.4044.92 (uplift to 1.8.x) #5190

merged 1 commit into from
Apr 9, 2020

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Apr 8, 2020 •
edited
Loading

Uplift of #5150
Fixing brave/brave-browser#9000
Related brave/brave-browser#9086

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@bsclifton
Merge pull request #5150 from brave/81.0.4044.92_master_35
db3f024 
Upgrade patches from Chromium 81.0.4044.83 to Chromium 81.0.4044.92
@bsclifton bsclifton added this to the 1.8.x - Beta milestone Apr 8, 2020
@bsclifton bsclifton requested a review from a team April 8, 2020 05:29
@bsclifton bsclifton requested a review from bridiver as a code owner April 8, 2020 05:29
@bsclifton bsclifton self-assigned this Apr 8, 2020
@bsclifton bsclifton mentioned this pull request Apr 8, 2020
Merged
4 tasks
@bsclifton
Copy link
Member Author

Failed on macOS; going to re-run on that platform only (others all passed/all green)

@bsclifton bsclifton added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Apr 8, 2020
@bsclifton
Copy link
Member Author

1 failed browser test; I don't believe this is related

17:39:43  [  FAILED  ] BraveRewardsBrowserTest.NotVerifiedWallet, where TypeParam =  and GetParam() =  (6401 ms)
17:39:43  [507/507] BraveRewardsBrowserTest.NotVerifiedWallet (6568 ms)
17:39:43  1 test failed:
17:39:43      BraveRewardsBrowserTest.NotVerifiedWallet (../../brave/components/brave_rewards/browser/rewards_service_browsertest.cc:2323)

kjozwiak
kjozwiak approved these changes Apr 9, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.8.x approved after deliberating with @brave/uplift-approvers. Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@bsclifton bsclifton merged commit 5c04843 into 1.8.x Apr 9, 2020
@bsclifton bsclifton deleted the 1.8.x-c81 branch April 9, 2020 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@bridiver bridiver Awaiting requested review from bridiver bridiver is a code owner

Assignees

@bsclifton bsclifton

Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS
Projects
None yet
Milestone
1.8.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@bsclifton @kjozwiak