Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 81.0.4044.83 to Chromium 81.0.4044.92 #9000

Closed
bsclifton opened this issue Apr 2, 2020 · 1 comment · Fixed by brave/brave-core#5150 or #9001
Closed

Upgrade from Chromium 81.0.4044.83 to Chromium 81.0.4044.92 #9000

bsclifton opened this issue Apr 2, 2020 · 1 comment · Fixed by brave/brave-core#5150 or #9001

Comments

@bsclifton
Copy link
Member

bsclifton commented Apr 2, 2020

Description

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/81.0.4044.83..81.0.4044.92/?pretty=fuller&n=10000

Test plan

Usual Chromium minor bump manual pass
Additionally, QA should pay special attention to the items noted in #8308 (comment) which are:

Affected areas:

  1. Themes (specifically, correct themes for private/tor/guest, theme switching, multiple profiles).
  2. Top site suggestions.
  3. Profile menu/avatar.
  4. History UI.
  5. Google messaging (setting is preserved on upgrade, en/disabling functions).
  6. Ads notifications on Mac OS 10.15.[1-2] and 10.15.3+.
  7. Settings UI: privacy page.
  8. Shields Settings migration:
  • check that shields settings are migrated on upgrade (all settings should remain, except no settings should retain protocol or port, e.g. if there was a setting blocking cookies on http://brave.com:8080 it should become just brave.com).
  • check that shields work properly (after upgrade or non-upgrade scenarios).
@bsclifton bsclifton added this to the 1.9.x - Nightly milestone Apr 2, 2020
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 15, 2020

Verification passed on

Brave 1.7.95 Chromium: 81.0.4044.92 (Official Build) (64-bit)
Revision e98e6f21168a55e7ba57202f56323911cd9d31d1-refs/branch-heads/4044@{#883}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verification passed on

Brave 1.7.95 Chromium: 81.0.4044.92 (Official Build) (64-bit)
Revision e98e6f21168a55e7ba57202f56323911cd9d31d1-refs/branch-heads/4044@{#883}
OS Ubuntu 18.04 LTS

image


Verified passed with macOS Mojave 10.14.6 x64

Brave 1.7.95 Chromium: 81.0.4044.92 (Official Build) (64-bit)
Revision e98e6f21168a55e7ba57202f56323911cd9d31d1-refs/branch-heads/4044@{#883}
OS macOS Version 10.14.6 (Build 18G3020)
  1. Themes

    • Confirmed normal/private/tor/guest windows used expected theme when Brave Colors was set to "same as macOS" (using Mojave). Confirmed theme persisted on relaunch.
    • Confirmed normal/private/tor/guest windows used expected theme when Brave Colors was set to "Light" (using Mojave). Confirmed theme persisted on relaunch.
    • Confirmed normal/private/tor/guest windows used expected theme when Brave Colors was set to "Dark" (using Mojave). Confirmed theme persisted on relaunch.
    • Confirmed able to switch between options (same as macOS, Light, Dark) and windows were themed as expected.
    • Confirmed theme persisted on upgrade from previous version.
    • Confirmed theme change with multiple profiles.
  2. Top Site Suggestions

    • Confirmed top site suggestions were retained on upgrade, including pinned status
    • Confirmed able to remove/pin/unpin top sites on upgrade
    • Confirmed able to get new top site tiles auto generated/added when others deleted on upgrade
    • Confirmed able to populate top site suggestions on a new profile
    • Confirmed able to remove/pin/unpin/add top sites on new profile
    • Confirmed able to Undo/Restore/X when removing a top site
  3. Profile menu/avatar

    • confirmed avatars were retained on upgrade
    • confirmed avatars were populated as expected on new profiles
    • confirmed able to access profile menu, buttons were in Brave style
    • confirmed able to create a new profile from profile menu
  4. History UI

    • Confirmed history UI matched previous version
    • Confirmed history displayed on upgrade
    • Confirmed history populated on new profile
    • Confirmed able to open/delete items from history
  5. Google messaging

    • confirmed google message setting is preserved on upgrade
    • confirmed setting still works on upgrade profile
    • confirmed able to toggle the setting on upgrade profile
    • confirmed able to toggle the setting on clean profile
    • confirmed setting is retained on relaunch
    • confirmed setting works using https://gauntface.github.io/simple-push-demo/
  6. Ads notifications on 10.15.x

    • cc @kjozwiak to confirm ad notifications on Catalina
  7. Settings UI: privacy page

    • confirmed brave://settings/privacy matches previous version, except for logged issue below
  8. Shields Settings migration

    • confirmed shield settings were maintained on upgrade
    • confirmed protocol/port removed on upgrade (confirmed for Cookies and Javascript settings)
    • confirmed shield toggles worked as expected after upgrade
    • confirmed shield toggles worked as expected on clean profile

Issues found/encountered:


Verified passed with macOS High Sierra 10.13.6

Brave 1.7.95 Chromium: 81.0.4044.92 (Official Build) (64-bit)
Revision e98e6f21168a55e7ba57202f56323911cd9d31d1-refs/branch-heads/4044@{#883}
OS macOS Version 10.13.6 (Build 17G12034)
  • Performed quick checks of themes (light/dark, no "same as macOS" available on High Sierra), confirmed no obvious theme issues observed

Verification PASSED on macOS 10.15.3 x64 using the following build:

Brave | 1.7.98 Chromium: 81.0.4044.113 (Official Build) (64-bit)
-- | --
Revision | e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}
OS | macOS Version 10.15.3 (Build 19D76)
  • Went through and ensured Ad notifications were working under Catalina
    • ensured view, clicked, landed, dismissed` worked as expected
  • Went through and ensured Shields Settings migrated without any issues
    • ensured that protocol/port number was removed from Scripts and Autoplay
  • Went through and ensured Google messaging was working as expected

@bsclifton bsclifton added the Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) label Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment