ICO/ICNS Revision #489
Merged
ICO/ICNS Revision #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- stylistically nothing in these icons have changed. they have the same appearance and logic as PR#437 - structurally the icons now each contain additional system sizes to account for correct rendering in previous operating systems where 1024x1024 wasn't being scaled (specifically sub 10.13 releases) - this includes 16x16, 32x32, 48x48 and 256x256 for Windows ico files - this includes 16x16, 32x32, 128x128, 256x256 and 512x512 in both regular and @2x retina resolutions for ICNS app files - i noticed a document .icns file hanging out in the theme folder with a chromium logo. unsure where this lives user facing but regardless all chromium logos must be banished
- updated a grammatical error for 'The Senate" - noticed two small grammatical errors related to colons
|
Made an additional small commit attached to this for revising a few grammatical errors in the NTP. Fixes brave/brave-browser#1271 |
bbondy
approved these changes
Sep 26, 2018
petemill
pushed a commit
to petemill/brave-core
that referenced
this pull request
Jul 5, 2019
…ly-tip-usd don't show USD conversion in wallet monthly tip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#1217 and possibly fixes brave/brave-browser#1237. Regardless these are non damaging positive aesthetic updates for the app icons to render edge case sizing and older operating system icons better.