some versions of macOS do not show Brave icon after mounting dmg

[LaurenWags]

Description

Older versions of macOS (Sierra, El Capitan, Yosemite), do not show the Brave icon after the dmg file has been mounted.

Steps to Reproduce

1. On an older version of macOS (such as 10.12.6), download latest dmg file from GitHub (I used https://github.com/brave/brave-browser/releases/tag/v0.55.5).
2. Mount the dmg file.

Actual result:

Brave Browser Dev icon is not the branded one:

Expected result:

This is what you get when using 10.13.6:

Reproduces how often:

Easily

Brave version (chrome://version info)

I'm downloading 0.55.5.

Reproducible on current release:

no

Website problems only:

• Does the issue resolve itself when disabling Brave Shields? n/a
• Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

@kjozwiak found that these versions reproduce the issue:
• 10.12.6 (Sierra) - reproduced
• 10.11.6 (El Capitan) - reproduced
• 10.10.5 (Yosemite) - reproduced

Additionally, currently downloading from https://brave.com/download-dev/ downloads 0.55.3, which does not have this issue.

Possible related issues:
#1105
#1101
brave/brave-core#437

cc @rossmoody

[LaurenWags]

Verified passed on 10.12.6 x64

Brave	0.55.10 Chromium: 70.0.3538.22 (Official Build) beta(64-bit)
Revision	ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS	Mac OS X

cc @kjozwiak to check older versions

[kjozwiak]

Went through verification using the following build under macOS 10.10.5 x64 - PASSED

Brave	0.55.10 Chromium: 70.0.3538.22 (Official Build) beta (64-bit)
Revision	ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS	Mac OS X

Went through verification using the following build under macOS 10.11.6 x64 - PASSED

Brave	0.55.10 Chromium: 70.0.3538.22 (Official Build) beta (64-bit)
Revision	ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS	Mac OS X

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave	0.55.10 Chromium: 70.0.3538.22 (Official Build) beta (64-bit)
Revision	ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS	Mac OS X

[kjozwiak]

@bbondy @rebron looks like we're not supporting OSX 10.9.5. I'm assuming we inherited this from Chromium which is expected. However, even though it's not supported and the icon has a X over it, you can still move the application to wherever.

I personally don't think this is an issue because we can't really stop folks from moving a executable. but wanted to check with you guys. You can move it around, but won't be able to launch it.

[bbondy]

Possible to compare to Chromium or Chrome?

[kjozwiak]

@bbondy when downloading Chrome using OSX 10.9.6, you'll end up downloading 65.0.3325.181 (Official Build) (64-bit) which I'm assuming is the last CR that is supported under OSX 10.9.6.

This is what you'll get when you attempt to install the latest Chrome on OSX 10.9.6:

Pinged @jonathansampson and @bsclifton as we probably should change our minimum requirement from for macOS 10.9 or later -> for macOS 10.10 or later (same thing as Chrome). I'll create a new issue our website repo and all the needed info.