Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align App Channel Iconography and Naming Convention #1101

Closed
rossmoody opened this issue Sep 12, 2018 · 2 comments · Fixed by brave/brave-core#437
Closed

Align App Channel Iconography and Naming Convention #1101

rossmoody opened this issue Sep 12, 2018 · 2 comments · Fixed by brave/brave-core#437
Assignees
Labels
design A design change, especially one which needs input from the design team polish Nice to have — usually related to front-end/visual tasks QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes

Comments

@rossmoody
Copy link
Contributor

Description

There seems to be a multitude of Brave app icons and naming conventions for the various channels we are soon to release floating around. Most immediately we are using a dated app icon for the Dev build and have some sizing errors for the App icons themselves. They are currently sized at 512x512 and do not fill the whole art board whereas they should be 1024x1024.

Also, we currently have mixed naming conventions for the App versions (some including "Browser" and some not) and the titles of the apps contain hyphens which results in looking unpolished in the dock.

A few other tiny issues include needing to update the typeface in the labels from Helvetica to Brave's headline brand standard Poppins. There is some confusing color theory around the legacy Nightly icon as it is easily confused with a Dev icon since they are both blue. Lastly we included a version of the Brave logo without a face which isn't ideal even in instances of internal use so that was updated to correctly refer to the monochrome version which I believe is being used now currently anyway so no noticeable update will happen there.

Legacy Channel Iconography

image

Updated Iconography

image

@rossmoody rossmoody added polish Nice to have — usually related to front-end/visual tasks design A design change, especially one which needs input from the design team labels Sep 12, 2018
@rossmoody rossmoody self-assigned this Sep 12, 2018
@rossmoody rossmoody added this to the 1.0 milestone Sep 12, 2018
@bbondy bbondy modified the milestones: 1.0, Releasable builds 0.55.x Sep 13, 2018
@bbondy bbondy added the QA/Yes label Sep 27, 2018
@srirambv
Copy link
Contributor

srirambv commented Oct 9, 2018

Verification Passed on

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Linux
  • Verified Beta and Dev build icons

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta(64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Mac OS X
Brave 0.56.2 Chromium: 70.0.3538.35 (Official Build) dev (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Mac OS X

Went through verification using the following build under Win 10 x64 - PASSED

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta(64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Windows
Brave 0.56.2 Chromium: 70.0.3538.35 (Official Build) dev (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Windows

@kjozwiak
Copy link
Member

kjozwiak commented Oct 11, 2018

Adding the QA Pass labels as the dev & beta iconography has been checked on the three platforms. Unfortunately, we can't check Release, but it should be pretty obvious if there's issues once we get the builds. I don't think there's any need to wait till we get released builds to label this as passed. In addition, going through #1105 will result in double checking this as well. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team polish Nice to have — usually related to front-end/visual tasks QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants