Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of SKU system #4869

Merged
merged 18 commits into from
May 1, 2020
Merged

Implementation of SKU system #4869

merged 18 commits into from
May 1, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Mar 6, 2020

Resolves brave/brave-browser#7595
Resolves brave/brave-browser#8938

Submitter Checklist:

Test Plan:

1. Uphold funds AC

  • start browser with short interval
  • enable rewards
  • connect to KYC uphold
  • add some verified sites to AC table
  • wait for AC to be triggered
  • make sure that amount was taken out of uphold card
  • make sure that AC was recorded in summary and monthly report
  • make sure that in logs we sent tokens to /v1/votes

2. Anon user funds AC

  • start browser with short interval
  • enable rewards
  • restore wallet with user funds
  • add some verified sites to AC table
  • wait for AC to be triggered
  • make sure that amount was reduced from the balance
  • make sure that AC was recorded in summary and monthly report
  • make sure that in logs we sent tokens to /v1/votes

3. Anon user funds tips

  • enable rewards
  • restore wallet with user funds
  • go to verified site and do one time tip
  • make sure that amount was reduced from the balance
  • make sure that tip was recorded in summary and monthly report
  • make sure that in logs we sent tokens to /v1/votes

4. Anon user funds Monthly donation

  • start browser with short interval
  • enable rewards
  • restore wallet with user funds
  • go to verified site and add it to monthly recurring
  • wait for recurring to be triggered
  • make sure that amount was reduced from the balance
  • make sure that monthly was recorded in summary and monthly report
  • make sure that in logs we sent tokens to /v1/votes

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc self-assigned this Mar 6, 2020
@NejcZdovc NejcZdovc changed the title Removes anonize ac approach Auto-contribution for Uphold via SKU system Mar 6, 2020
@NejcZdovc NejcZdovc force-pushed the ac-sku branch 13 times, most recently from d3433bf to da61a59 Compare March 13, 2020 10:09
@NejcZdovc NejcZdovc force-pushed the ac-sku branch 10 times, most recently from 86846c8 to 6a4ec7b Compare March 21, 2020 21:21
@NejcZdovc NejcZdovc changed the title Auto-contribution for Uphold via SKU system Implementation of SKU system Mar 22, 2020
@NejcZdovc NejcZdovc force-pushed the ac-sku branch 3 times, most recently from 2ef5e9f to bf723bd Compare March 23, 2020 08:03
@NejcZdovc NejcZdovc force-pushed the ac-sku branch 3 times, most recently from 94dd7b4 to 67cafe1 Compare May 1, 2020 05:13
@NejcZdovc
Copy link
Contributor Author

CI failed on windows dist, not related to the PR. Everything passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uphold auto contribute has incorrect processor in DB AC with virtual grants flow with uphold funds
8 participants