-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of SKU system #4869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
changed the title
Removes anonize ac approach
Auto-contribution for Uphold via SKU system
Mar 6, 2020
NejcZdovc
force-pushed
the
ac-sku
branch
13 times, most recently
from
March 13, 2020 10:09
d3433bf
to
da61a59
Compare
NejcZdovc
force-pushed
the
ac-sku
branch
10 times, most recently
from
March 21, 2020 21:21
86846c8
to
6a4ec7b
Compare
NejcZdovc
changed the title
Auto-contribution for Uphold via SKU system
Implementation of SKU system
Mar 22, 2020
NejcZdovc
force-pushed
the
ac-sku
branch
3 times, most recently
from
March 23, 2020 08:03
2ef5e9f
to
bf723bd
Compare
NejcZdovc
force-pushed
the
ac-sku
branch
3 times, most recently
from
May 1, 2020 05:13
94dd7b4
to
67cafe1
Compare
CI failed on windows dist, not related to the PR. Everything passed |
This was referenced Jun 1, 2020
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#7595
Resolves brave/brave-browser#8938
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
1. Uphold funds AC
/v1/votes
2. Anon user funds AC
/v1/votes
3. Anon user funds tips
/v1/votes
4. Anon user funds Monthly donation
/v1/votes
Reviewer Checklist:
After-merge Checklist:
changes has landed on.