Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC with virtual grants flow with uphold funds #7595

Closed
NejcZdovc opened this issue Jan 4, 2020 · 7 comments · Fixed by brave/brave-core#4869
Closed

AC with virtual grants flow with uphold funds #7595

NejcZdovc opened this issue Jan 4, 2020 · 7 comments · Fixed by brave/brave-core#4869

Comments

@NejcZdovc
Copy link
Contributor

If user has user funds (uphold) we need to have a way to covert this BAT into unblinded tokens. We will be using new SKU flow to accommodate that.

@NejcZdovc NejcZdovc added feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. QA/Blocked labels Jan 4, 2020
@NejcZdovc NejcZdovc added this to the 1.3.x - Beta milestone Jan 4, 2020
@NejcZdovc NejcZdovc self-assigned this Jan 4, 2020
@LaurenWags
Copy link
Member

@NejcZdovc does this issue also cover the AC notification on the BAT logo? Meaning, if I do an auto contribute with an Uphold KYC'd wallet using 1.3.97, the AC appears to go thru (my wallet balance is decreased), but I don't get a notification on my BAT logo.
4133-KYCdwallet
(note - the AC also isn't listed in the summary, this is covered with #7526)

@NejcZdovc
Copy link
Contributor Author

@LaurenWags this is a separate issue. Can you please double check if everything is ok on 1.2? Please log if you can reproduce this. Thank you

@LaurenWags
Copy link
Member

Does not reproduce in 1.2.x.

Additionally, found a second scenario in which there's no AC notification.

Logged #7836 to cover both cases. If they should be separate lmk - happy to log another issue if needed.

@05K4R
Copy link

05K4R commented May 28, 2020

Is this one confirmed to fix the Bat Ledger Service CPU issue, or do we need to wait for brave/brave-core#5568 as suggested in #8846?

@GeetaSarvadnya
Copy link

This issue will be tested once #10058 is fixed, as AC needs to be tested with multiple publishers.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 12, 2020

Verification passed on


Brave | 1.10.90 Chromium: 83.0.4103.97 (Official Build) (64-bit)
-- | --
Revision | 326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS | Windows 10 OS Version 1803 (Build 17134.1006)


1. Uphold funds AC

  • Verified that the AC is successful for multiple verified pubs using funds from uphold account
  • Verified that Recurring and one-time tips are processed
  • Verified AC amount and pubs listed in DB
  • Verified that the Processor value is displayed as 2 in conribution_info table
    image
    image
    image
    image
    image
    image
    image
  • Verified that tokens are sent to .../v1/votes
[ REQUEST ]
> url: http://payment.rewards.bravesoftware.com/v1/votes
> method: UrlMethod::POST
> content: {"credentials":[{"publicKey":"mMMWZrWPlO5b9IB8vF5kUJW4f7ULH1wuEop3NOYqNW0=","signature":"jh72CYJTGx4D5DV1kHimorKJnA5miAW8bDXj18QVNPiOpKlI+HOrBtcEztkeFaqrCyNJnWyq4DYsC/KOZa2cLg==","t":"3uZC8VZPS6I20jCj8itAeTqIgGtOWJMKeoOqkt/Mlze+gIBqSO28pDk9m8pXkg4/E51fBJ7X+PrzB9KBOKRPUw=="},{"publicKey":"mMMWZrWPlO5b9IB8vF5kUJW4f7ULH1wuEop3NOYqNW0=","signature":"W6/zLjAWaxiWN4uvHQGItsTpAt5vjMAWSAYaOX53xMdKghFgUaCfmlMJzIYfGuMoHzqDl1YVJLBMwGke3m1QxQ==","t":"xy+ylNBhZpAQYYEZ5JyynO+GIz5uGT3Qf+UWBfrgcRwCjBsAVaQrs1v07CmOiRzXakiPJ0tQ9rhaT1U0bRmLyQ=="},{"publicKey":"mMMWZrWPlO5b9IB8vF5kUJW4f7ULH1wuEop3NOYqNW0=","signature":"JAjh8UATcLHUL3ctDw2J5SUzxJNCsDk7F1wyNSh5GYBaWvmF95I7thd43hcbJ/u8tZolk70JTayPaU0mKxPw+g==","t":"H0wVWUN1A/yrpGI6KLdXyV1N9wmqBywzgFgAeLq3bOQHBNo9kbPgFwr2Fh94Tfa4oqnZJchwER0spKSaZLGC6w=="},{"publicKey":"mMMWZrWPlO5b9IB8vF5kUJW4f7ULH1wuEop3NOYqNW0=","signature":"Rs+3K3FXa21OAn4aRKhbSTPzZKB0TBKe/GKfcByhOOA4yrPmP7vFATBtJzMS94Kg8N4MseFq5urR8DUcgM94lg==","t":"/YwPRqlhkn/uYrHvy7b+9s9HA8pTjCU9eD28FU+4IfYYGQp3yPPOJRD7deqk00SIKMgFXQizzAxu4U3Q89eaPg=="},{"publicKey":"mMMWZrWPlO5b9IB8vF5kUJW4f7ULH1wuEop3NOYqNW0=","signature":"pzjVSguEFvN+CO0NiqhkMf39c/c2pBLlfAfbgET6DJDrxvSa9yXQ0+szYAwvF6P5lLXuKa46SqT0gLvBfuNMSA==","t":"MEZJfVxmpzduK/mFG7bhD7TNnklwg0Om0pevblK09hQ6aG5qFtzP8Rhlqi4YmujAnpMUbeNYgZSrakHQWI2l0w=="},{"publicKey":"mMMWZrWPlO5b9IB8vF5kUJW4f7ULH1wuEop3NOYqNW0=","signature":"LxKiQHvUJRnbSg2fK5hYbrk6dALys5x6M4JCsHiFeEOqOiYnyn70rDYVmUioOvhVDXrvmnTThymSwod1nH9Ayg==","t":"KzJTbArgoDVapdDC1XHdjviMIyZvfL+/biD3OW5hj/Dj4V4TreHp3B67fVZFJgzZXuTMDgJmVzg2W8MeR1GVqQ=="},{"publicKey":"mMMWZrWPlO5b9IB8vF5kUJW4f7ULH1wuEop3NOYqNW0=","signature":"YKSlyr7La6YEF3WX/gk8vIk1udl56eYx/K0SQtPcvYxWGEd2o4t5kzDAkBhqWajNXRYyjJtcAxvF5z3D/srHeQ==","t":"KQyLzaZETBTrw/WAdtrGTyRZBlMSfwsrav6822IgDUdcYwhl3pQjkONT4W4VsCOftn/93a/NwxNbCho9m8RKgQ=="},{"publicKey":"mMMWZrWPlO5b9IB8vF5kUJW4f7ULH1wuEop3NOYqNW0=","signature":"HuSqRcgVxlIltfnmIjWAw2vVD8uGKNhVXundkp5AC7TulTKGSQfrTousuW1Y4MIdI40G9yAOpnMHgSSrPuntCA==","t":"x/a2aJK7TAGrxUXS7yFGJpaM3lO9P+Dq/Eteewdfzdn4lJMz62Fgs3Qy9EnORDzB1QWPf7OfZY5QzONzY2MOzA=="},{"publicKey":"mMMWZrWPlO5b9IB8vF5kUJW4f7ULH1wuEop3NOYqNW0=","signature":"qrbvHp51Noo+vLZ5RL/7pM4SpmFn7Tofb1Gu2v8NfdE2c2fI/ur+5JXucIeOy3rEU0Fi3aWcO6R4wNf4ZoFGeQ==","t":"p9vAI5cGfgG9+kJ8bi9X1uzD0Mhzislakad4i4a1RjzHW0RZzhhQ+w4lvVeemrvZRc77/RGCshX4xiZpf6ZPxw=="},{"publicKey":"mMMWZrWPlO5b9IB8vF5kUJW4f7ULH1wuEop3NOYqNW0=","signature":"FriRdHU1m26r3DuF7ZZzh7qiMJ3DUaj//JZyoV42i2CkZg2O4BnFczWCaEhDcUcKCxAW3THv9gLMrPai0XejeA==","t":"zG+VwtI2n8zZioWNc/KuAIG8UDnXdDVOxI051jWR2SEmHrRMzHLXPO69A9RCHJXpdzgqH8dPXCSNA+JVK7a4/A=="},{"publicKey":"mMMWZrWPlO5b9IB8vF5kUJW4f7ULH1wuEop3NOYqNW0=","signature":"Ks6EY/Er4pFWhPqMbqPNVWZmKcPEWKJq3bBF7YiCeJnLQFZ6m6UfUW8zhoOcxmebg7q8E8oqTKiWjRUNKiO6tA==","t":"eU89fU/ZhcBEdPyCkEtHjZm1aEgD1cvq+xW79LqUgTLBaOjF0Gh8zPB3vsK+RV3kEs2tGlX91N1ya2Qsj0BMVQ=="},{"publicKey":"mMMWZrWPlO5b9IB8vF5kUJW4f7ULH1wuEop3NOYqNW0=","signature":"etwG3ZI0+29j9WadW7Cy8ierqpeCjQJNpqES1qpuyEwakCQ4jZkN+epQvMMeC9p7AgQTejewgRJJfv6KKJF0/Q==","t":"lT9Oi76eK0C2DdbJuy0CFnJ33OlaCh8+gG2THknZbMljY+hdHviCBCdGvZfdrri0DQwGW0KDy5LfvxbyuyVAxg=="},{"publicKey":"mMMWZrWPlO5b9IB8vF5kUJW4f7ULH1wuEop3NOYqNW0=","signature":"iLPj3eIRg7VT4qZuvVoZm/E+dL+iKmniwoBMax2OL+9YBYx24KGBV6xZwwmzn2wLIkZ/4uf48bSBzfLERIUjQQ==","t":"ZZtazMiLfMWsJv4ivK/Z5AcZv36QM7HpOQYUmEdbxjSWZ1JrcC42N8cpCeUaYUIuSnDs/DTOiQne3aYsdR3X9Q=="},{"publicKey":"mMMWZrWPlO5b9IB8vF5kUJW4f7ULH1wuEop3NOYqNW0=","signature":"+EGjS6KF/25EgWFBMFbTppRZZ1QBjBVDS1jNImN5nxK6TD9+dCgiNtGvjGY6dSBdX+0q6l9rG8mgH/7bgpEHpw==","t":"KHWRDWoeBbPH8hj9WeYM4BaHv4DXwP1/cFDCuIOdhbbCR6BOsgVTs8xeAxT62msqsWldB5kMkoOnaLztiXqPNQ=="}],"vote":"eyJjaGFubmVsIjoibGF1cmVud2Fncy5naXRodWIuaW8iLCJ0eXBlIjoiYXV0by1jb250cmlidXRlIn0="}
> contentType: application/json; charset=utf-8
[ END REQUEST ]
[17876:10432:0612/162022.837:VERBOSE1:ledger_impl.cc(1020)] 
[ RESPONSE - OnRedeemTokens ]
> time: 1591959022
> result: Success
> http code: 200

2. Anon user funds AC

  • Verified that the AC is successful for multiple verified pubs using restored wallet funds
  • Verified that Recurring and one-time tips are processed
  • Verified AC amount and pubs listed in DB
  • Verified that the Processor value is displayed as 3 in conribution_info table

image
image
image
image
image
image
image
image

  • Verified that tokens are sent to .../v1/votes
[ REQUEST ]
> url: http://payment.rewards.bravesoftware.com/v1/votes
> method: UrlMethod::POST
> content: {"credentials":[{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"++XzoPvoj1GSBENgFFFVLDKlnqYvYv0XMtWvCXm0MpdLN8lsmjA7STgOXgRIvHIRdMPZJwXTwP3++/PP3OAxsg==","t":"moS3RNadTKfrhZU8XzEFrPdM34jViTTi+9J21uPWDuZ+SankyInqkA3U3zoAomuiTYnTns9w+ukV2lft5a4U0Q=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"3lVRclC+El62WcflKRqh1VCut2M3PwjUmD5Ll6Ah0OpbzUFn/DnrsyBgfgTt6sJb4w0q99nISMBK6hX8gO/oHA==","t":"q5HEiLKpZeWForbTnAyf31B8Nfs+qa1jLzm0XC1gILXYTfQUaFAiJ8hCs65WOh2mdbNxWb5JqNSnPC/J6leHrg=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"TIOnyexpJPNkBGCxnSVwRNRgc5ITXl8BrVxkpMZO6PLphkjR60gtuD6MNq7v0OGPPU6UyLMFZLzRWw94/WaIEA==","t":"5Nyzi76lzSt8vQ8q+G0HWMIKJvOXxhiJghwZ8B5y3lWRlJzpzCALFO6Elchkqak9xBqLOpYlx9uwPKGTly2SVQ=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"IBTiaX21JmVcD+ITwidwztglieWaonsmFACV9SaDsMWKMQ7bhEQKUCasAVFKvLVUUZ+LqD4z4fRerdkBJJ9f1A==","t":"+UuZcyZru7GAZO0quYcLuBGKEt83JghrGuiVig0MAndNAt1eCtK0hk9ubi6o8RbWpnes/CGnSro7WkOhv6mICg=="}],"vote":"eyJjaGFubmVsIjoiM3pzaXN0ZW1pLnNpIiwidHlwZSI6InJlY3VycmluZy10aXAifQ=="}
> contentType: application/json; charset=utf-8
[ END REQUEST ]
[36064:29864:0612/163151.399:VERBOSE1:ledger_impl.cc(1020)] 
[ RESPONSE - OnRedeemTokens ]
> time: 1591959711
> result: Success
> http code: 200

3. Anon user funds tips

  • Verified that the one-time tips are processed using restored wallet funds
  • Verified that one time tips can be sent to Twitter, Vimeo, Github, YT, Reddit and regular verified pubs including custom banner pubs.
  • Verified that tips were recorded in the summary, panel and monthly report
  • Verified one time tips and pubs listed in DB
  • Verified that the Processor value is displayed as 3 in conribution_info table
    image
    image
    image
    image
    image
    image
  • Verified that tokens are sent to .../v1/votes
[ REQUEST ]
> url: http://payment.rewards.bravesoftware.com/v1/votes
> method: UrlMethod::POST
> content: {"credentials":[{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"ea9SZDEJRvgMQebkqgDqlOxyePQqUesg7QhrdIqokMWmYGP2P+n886A/2jDtdteNlTwohtgP0qSveKninca2Lw==","t":"Bla51HXYa/nPLZgYwmtubVXGj00qI2DQaoMuWT2gVK4OsCSZ3BpOeNwdlb9guw9m1FlDfqDy6euUpo9JPy+NvQ=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"1Dt0h5bXYRSyhucBlFOvlC3rBOjeZiWv2OXCOkRIT7bjDLYMMMCMxVt1bkGz5tFLrm46tLQwvKwMjQpz1OGKug==","t":"gp+7rPYNH2l3NyC3VTfjT36gPPoHukk1IvN84V5Sjed1eWw+taAxJta2bjdzDt72HlxFp1sSXonDKx+y2yckBA=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"1abbTErVlb0oB0aQNNFVgvY6c+MtGvQk97kPiyGMS/wsbqWnaof/hlPdIcOrcFP5vuKLgMeFTpQw4LSbox2W4Q==","t":"QG8eM+WDnRxLFbW0bl0Tz0KuO0Y18bbwgSA4HOwz4C8VJwtU3Hn9TJ/xVRGcn3oYPPG7Jc05y3fbKNvd2WZ4rg=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"TmMduGN/jATambVjLaAveBHMZKQYtTMoP7IOlj1F5n2Av10cl+NvfAmnPvJ8Qrba71l2b1+RDmmOxCkE0kf69A==","t":"PvN3N/LSXFQuO2KaYJjyhtiiUOA31hHjIra9VLKrsf+5L74YAGXhQcf7T6BMcjcLLUssXHAon3iK9BOQpKZk8w=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"aTVd5q1SQf3gp3VJJLwKx4pIk5lTMzznpHmPuNoo2tn2Tjff7x5qsEetxZEynfDbZ42YuoWYbDVaRdIlTT35RA==","t":"/XgN7MkXG/knxO/ZEyR4uK30UYomc8ASJ559VunUFnqUulgrEMGheggU8CVGMK9icT6ZXQNFErrDJvk1UIwNYg=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"bDtqPAEzh/jNvBkTSFEz8KfiHsLx7DAd3GsccwquZqEnq3hoV39cObPNA2nGRlDDSJ6cYbK8plTCz6oOu7Td6Q==","t":"OpeVgPQiyb5GetpLs2UH7NPTYuzrse9Fz/UbJ5ARVg7CZazjR9yC9L9gXvGRQcLgjdkQt6pWu6zW15f8Tuca1g=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"fuauVNwAssr5E/yYcPar68gPx1hSWEM9o98j6RXpG7gE+sDHVNNSkI9dZeDUSPyeoQzWFsGyhAPJzSdlbAdhBA==","t":"RmwOVkY6xV4/cMuc2uZ8wZUUmZpdQrZ5+RzqCLdCwofBxyKV1iwnPg7NyJQEpgZcZB1QcvbWTnEQcrUkOFMzfg=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"cNIqvq8pDrzzdgLXQi1HzJ6GcUSwsefNI/f1nenHJ0GglzkQGelXyb8FwLnpvQIcN/9LMIVNUt2ax4hwkJlfmw==","t":"feFy79GD7kSA5jfTSHXH6ChACkgcOm3z+F+CxWDue+1NQEWfrE/OrciMjyn7DgpXmcIK1E5CnY/dXOzIXiWYEQ=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"jH0CHT6FiZsWVJV8hdV9lmZq0zTsxP1mTqGwPU8JYTBA0cviU165+yQGdrs0wLFroxXULKgCyCuE+2GWTKI8kA==","t":"+n6WxcZxficedXBvVFDANa7q7+O10SrziZbKbHFqEFfWTPUAlq1m7+nRjwdjUSyM81e2VRZmCf5XhQMCN8atRA=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"pVNSnZCdIwDN9d2PvXZU8NhbDmKTvPsCvY1WTZhGaBb5kZQFMWZyh2eFDloXuyoVgua7M959qo8wthlgb+EBBA==","t":"g0jMxFKjD19l8O65vVlzzoeCnKU2dlMRAbs1GLf7N9PwO5uz5vIUIjKfCoatvFkWEsU+nrCjkDDTz9Elh1p01g=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"mckVLrIdMd2eGxkR9oCaDyxI/tixPEPYNbcgSAM/ekUvTzTe83ohMCDN+GFnJNJuCfZkePjkO6uG5vlRq1fg9Q==","t":"+UkdCQZ5oNavBZINMcflw/QU4BmJ7ktDac0j3Uf3YFPDJUm1kI7x8yeOwoXuPQr5z+YBpabo9X4nJ6t6T6LcMw=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"05xo67u/V4hh8i9xBAlNQUTzMau3ePYdCEyzCquBZK28LcgLWViw0dzRATHxPUMGM+fI5ZY0bsH2uch7mQYShA==","t":"tsx2gob6h9d2UYIUZAkY9VmVTwtpjhQYxy1HuJBlTvoSeo5yEt3Q5AUvD3LhExFqNwTCYHY8wGaY8fxKUV2dvw=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"FG+2o5wy46e4W8Dse2cNyvQYnqytPTTKs/EbwqSxoCiSHW2zgF3i3Idlq6q9wd4x5tbdDpevT+l2rVbUO1IPSQ==","t":"/50tUwv+udNEKY1BojBMoLU4UYqpP3pBAj2UG9qxg4AKV5PJ+goAz36vVVqg87zIe6OoZSmyGuVKmgUQmbdhPA=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"tuIpnSb7FwDzQoVILG0IO39rQPoR8+1/d+HUCpsbEczbie90ceDEzmfJIBERNiSLc5FjqUUe/0Xk2Rnrq0FNUg==","t":"lkidcTQeDZOXOQsShadXJi7R4E9HayegsjwZZ6EBcA6qi4+bcPUz+k8o/CE4tK7W95ogPBgKtMNltEkKVx2ouw=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"ns81RBl3xsQiFs2so6Q+WV77flq6t5+bk6AcmhTZWDL31nb0OxWUickM3fd1FMddPnUybT2N7sIV+2PYHlkTsA==","t":"BKKBaarnMR6n8GMsCVcp7JWKqU6GHp+sQDOchmSdBNr/zgsSJp35F62sAFsswltjeyW0s7VGlsZYhiC3a7BLOQ=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"hnlqJD5+G/UDhazPvax9/WkV4dCpf6MMg/Lzcxt4gfh/OlU8BgG/Ye8cPokxh7GclFbEKzOdExu0fbzLf+8aMw==","t":"Bksl2uvlqMa7GZfrMN1J2cSPGEsyPpEWGLtW8mPNQMr2h837ttlXrPlKpoKS/Me+4tPgtWSHXeqxg1ljnyLA3Q=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"8JqAebauUzDhzx+1BlJ8QK/Wr2GIWkqNd93rVC65qRo4k2pli59I/xCWYnVXrnv338NuNuqJk98Cz+geUNtHag==","t":"Zukc/LQbQoFaPavHA/epFw/rZsKc34FsdXWVQIq6vXX27Xs4erMkWGM7dSW9rBXzuSD9YMqCwPoDE6SkZ0jxRA=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"uv/DMxA2RCzFDF3mBYBJWUUWrjNfPJWR+9j+2r/xBufB/6eyA0CpAuWT1IXRpUC96ovVL/gXKvtK/BvKUmUZ/g==","t":"6ImnllEYgWOJ8SPHVZeMIGivN6ookUUquXbGgLTPGbQbOKRI2qGZE6D2dXJpJiWzhoF/T2s39tg5FMP6m0810Q=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"KAnQacKDrVDn6Ax0VLcNM89Bqz98F8V0cEJkqVyJvgG9k53O9zjMT95xkyXFjzfgwp/muWuo+N32Znncvgc3BA==","t":"2fDIhhsHcvtxaAtc72wo/bVDls7VUq0taVHEIEP98AtVhBMT/eLDXBLmHd7LFp4AKfukYByVT47VMhoRtlX5tQ=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"vHtxEMEW/DCX2PfA5RwWN2QJjq/J+E8HMaU6/hL8qIF6Ud2LHfFYj/zRzQcwfoDoBSRmlmn9dY85ZPxKN1QOXg==","t":"kd8xbDnDu9p5aLhFvXJvPeSrvNzxP+tjxg9uF/L95a5GrYag2VXau4NT4LtFeF7hzt48jpaun6Hn1yX2EmiGdg=="}],"vote":"eyJjaGFubmVsIjoibGF1cmVud2Fncy5naXRodWIuaW8iLCJ0eXBlIjoib25lb2ZmLXRpcCJ9"}
> contentType: application/json; charset=utf-8
[ END REQUEST ]
[25488:34008:0612/165650.140:VERBOSE1:ledger_impl.cc(1020)] 
[ RESPONSE - OnWalletProperties ]
> time: 1591961210
> result: Success
> http code: 200

4. Anon user funds Monthly donation

  • Verified that the recurring tips are processed using restored wallet funds
  • Verified that one time tips can be sent to Twitter, Vimeo, Github, YT, Reddit and regular verified pubs including custom banner pubs.
  • Verified that recurring tips were recorded in the summary, panel and monthly report
  • Verified recurring tips and pubs listed in DB
  • Verified that the Processor value is displayed as 3 in conribution_info table

Note: In this scenario AC is also triggered along with recurring tips.

image
image
image
image
image
image

[ REQUEST ]
> url: http://payment.rewards.bravesoftware.com/v1/votes
> method: UrlMethod::POST
> content: {"credentials":[{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"vPBYHs6e+iRNOhoq3ty+k6lxAcRGFae0X5vVPxOu+5hNTe1BX6u8sJgXd3rBQBlhEelnpoe0UwTmCXVThJPHow==","t":"Bn0z7UlsbUgyZQz64Dv1vhd+7VGm+buVX1X+XqXz2pTNK1K5Qu5CvU6mkiR6Xi+Fc1SoZYqhbfy26te7vqB93A=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"QvjtQD9Ddjx/B9Dw5J2g8hM8X+xGPDO/B70aIDnE1Dcr560qQt4J645eRVbzDTrtudNn+C4TScUvxjzas5lVEQ==","t":"rRCv0s0EKMdwVJnmSz1A85F4ne4w0nLeniZAwVaEbKsUmkD9FEIGmgxDNdI4WHZ99rJjcf9PmZ5UcvIAtKtnfw=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"7onz9h8jxWvvNZoruPki0v7ZnTb029fTyJZ7p2pJACMJHsGOoF3qZWe5u3P+NNujV9EgK02wgvNSNt2rDJm+cQ==","t":"qgVlDB7J/0bZ4Du/7DzaJ/tRPG5Gy/A8RN5iK7viMNrMGG96lt3goValAzu+DmwuNInBK4tKPsX1moHgLb2zfw=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"24k+lRnj5CwmTbGBvPgROiMQWj34F3HgmqT/GmwcS5zsMb51xwDiMBriWhs8DYckrD87CFYBwgnw6rZ8g1RLDQ==","t":"+6iGwNFGBx+wmdWMtt1Pb1lu3UHK8GO9ZVjoahVo4HtLAqX9vKb+/6LFMhi3eoV7RkitKArHgwC6fnVkLa9X5A=="}],"vote":"eyJjaGFubmVsIjoiZHVja2R1Y2tnby5jb20iLCJ0eXBlIjoicmVjdXJyaW5nLXRpcCJ9"}
> contentType: application/json; charset=utf-8
[ END REQUEST ]
[33912:36524:0612/181325.692:VERBOSE1:ledger_impl.cc(1020)] 
[ RESPONSE - OnRedeemTokens ]
> time: 1591965805
> result: Success
> http code: 200
  • Verified the additional scenarios which are working as expected
### Test cases with a single funding source
7. Verify a one time tip, a monthly recurring contribution, and auto contribute can be performed using a wallet funded only with virtual grants (all using the same wallet/profile). Restart browser to confirm no unexpected contributions are made on restart.
14. Verify a one time tip, a monthly recurring contribution, and auto contribute can be performed using a wallet funded only with user funds (all using the same wallet/profile). Restart browser to confirm no unexpected contributions are made on restart.
21. Verify a one time tip, a monthly recurring contribution, and auto contribute can be performed using a KYC'd user wallet funded only with BAT from KYC'd Uphold wallet (all using the same wallet/profile). Restart browser to confirm no unexpected contributions are made on restart.
### Test cases with multiple funding sources (2 or more)
23. Have a wallet with VG BAT and BAT from a restored user wallet. Tip a verified publisher so that all VG will be used and remaining amount will come from user funds. Confirm tip is completed as expected without errors. Verify this is displayed in monthly statement and sources for BAT are correct. Restart browser to confirm no unexpected contributions are made on restart.
26. Have a KYC'd Uphold user wallet and BAT from a restored user wallet. Tip a KYC'd publisher so that all restored BAT will be used and remaining amount will come from KYC'd wallet. Confirm tip is completed as expected without errors. Verify this is displayed in monthly statement and sources for BAT are correct. Restart browser to confirm no unexpected contributions are made on restart. 
29. Have a KYC'd Uphold user wallet and VG BAT. Tip a KYC'd publisher so that all VG BAT will be used and remaining amount will come from KYC'd wallet. Confirm tip is completed as expected without errors. Verify this is displayed in monthly statement and sources for BAT are correct. Restart browser to confirm no unexpected contributions are made on restart.
31. Have a wallet with 30 BAT from VG, 10 BAT from a restored user wallet, and 10 BAT from KYC'd Uphold user wallet (total 50 BAT). Set AC to 50 BAT. Perform AC and confirm it is completed as expected without errors. Verify this is displayed in monthly statement and sources for BAT are correct. Restart browser to confirm no unexpected contributions are made on restart.

Verification passed on

Brave 1.10.90 Chromium: 83.0.4103.97 (Official Build) (64-bit)
Revision 326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS Ubuntu 18.04 LTS

1. Uphold funds AC

  • Verified that the AC is successful for multiple verified pubs using funds from uphold account
  • Verified that Recurring and one-time tips are processed
  • Verified AC amount and pubs listed in DB
  • Verified that the Processor value is displayed as 2 in contribution_info table

image
image
image

> url: http://payment.rewards.bravesoftware.com/v1/votes
> method: UrlMethod::POST
> content: {"credentials":[{"publicKey":"mMMWZrWPlO5b9IB8vF5kUJW4f7ULH1wuEop3NOYqNW0=","signature":"upKcoyLKqo7H5/HUoZvT84QTYOOTmedNP0G+wexdIx9tsIBR2csipDPIVsxdkAzu/7xbCGtNfJ3Z4N1GeOIlDw==","t":"DMwG05wrvts8VXLHnP5uS1eaxBZ76QbGijdiwfRtxKR0vSu0ukgKV1PiLVxqiCPWfZOWEMaRhCdnz+CSxcClMg=="},{"publicKey":"mMMWZrWPlO5b9IB8vF5kUJW4f7ULH1wuEop3NOYqNW0=","signature":"Soviw4BEBcUcgteIExnDA7mz4oJ9Rm7KLFjhraruWzz7Vc34Er20i+5oFFIYl/RSZUeajndy4aLABu8HZdOjig==","t":"t7wt/xQaOtbnJXR2JiOL9IAkrgTymXBwOCUu1206KoGEKCkUpjiLy89wLSQsdN3UylW1LzQOcsRO5IkMKMaDvQ=="},{"publicKey":"mMMWZrWPlO5b9IB8vF5kUJW4f7ULH1wuEop3NOYqNW0=","signature":"tKR1lXwPGp6npEDmSgQ3jDAiYlzRYH4RnC91HbxtqsizR6eozaF3eCs95rzSJfwCcnXHuTXoJv8R2e+cGK0rEA==","t":"oqdyajPkLDQdrE2AEoLBvoo267IW9M3rWqd5IL6pD0bwvDpmgv2slfGFkIaZ3CYusomCNZvth5RmeQppiPX8Dg=="},{"publicKey":"mMMWZrWPlO5b9IB8vF5kUJW4f7ULH1wuEop3NOYqNW0=","signature":"ZqenIEFtrOfBo3U1KGM28e22pGIWnO3VVlgv40QVOc3cuX0Gae7PAIvDoeDGsfD4bVY1U4X0HYO/8ddlkdrPdQ==","t":"4jpzomERN28sAiZNhuTavQrgDgtlalFugQGlRGCSQKyQfDKx/FIXhk9n9ycGjLYD3fsqz6Sjk8JKDCa6LSvJrg=="},{"publicKey":"mMMWZrWPlO5b9IB8vF5kUJW4f7ULH1wuEop3NOYqNW0=","signature":"jVT16ubKH9VswAbSz30wID4psxEI4MKKYZ4nPm0IQXCs9k00seM7xImx2YOEADnUGHxWJccoflSQjIy3tLjj7Q==","t":"P5bGP4XpBWmlqu0D421LeSBFYsCI4GpiVA/64KKTVV9aNNhihGpJpVEBPKsQ8ASgoMpo7WxH9/heUweBxcBLzA=="},{"publicKey":"mMMWZrWPlO5b9IB8vF5kUJW4f7ULH1wuEop3NOYqNW0=","signature":"ogk/CWYzVC29oDANOkjFnZZ89wzyrLVPv4vFFIzrayFMGcUq6MezH+q9O4ADneN0E5Tr3Hs86tw5kp8FJ8yK5g==","t":"NERL6TsDUlzM9122URp53sJh9UP6oDWrrzPK+DnVtvAf6u/uJxuVaaV84yg+ng1TmdDx+ecE7VgrDdgXeYNNZg=="},{"publicKey":"mMMWZrWPlO5b9IB8vF5kUJW4f7ULH1wuEop3NOYqNW0=","signature":"se/Qw0+vdrRa1xTGElvV6RrFVCTN89oNe7EVfdL43UXxdrxFrmw4B6yCjroG7wsazQ4xZuDBDqZZErAkfMOkvQ==","t":"MneibIU9TFWyOHJJ+uAs13NqemUTKwGTOtRbU9xOS7bPRAJhPzRG/GvvDoVd65V65dN/MRqi6nt/ZPqA87CFOg=="},{"publicKey":"mMMWZrWPlO5b9IB8vF5kUJW4f7ULH1wuEop3NOYqNW0=","signature":"p4tci6XjB/YR11bwAr+N+aTQxC4ZADymh/ZADZl8mcRqn0he8czJaNFG13AvQLSzYH2CmgCeD+GTJDnOM4Qo/g==","t":"rEAlfD2TyEp69qT70/QTavA5h1TMmlZoJkjiiy2NKUmBeWvkbQx9SPz9PmshS4WoezgKCUdhbSoTCWqPqgOwug=="},{"publicKey":"mMMWZrWPlO5b9IB8vF5kUJW4f7ULH1wuEop3NOYqNW0=","signature":"QiqGMbFWeOAMsNVBJATGonANOuHBURbVcxloNk2sdYVcq+5nHaqJsVH7d9TA2q6ym9wdMzc+TjeK/Atbp9eXFQ==","t":"ianRB2DCYfIbnBn99j+CbEYl0AtojE/mE1FM09Ii+aWK5HEK4jQZ4PyTOQt/HEH7SNQH9BLS1yG5OMmtsigTKQ=="},{"publicKey":"mMMWZrWPlO5b9IB8vF5kUJW4f7ULH1wuEop3NOYqNW0=","signature":"1wgvSHu1FHu3LSV+vIKcsv45wej3dOgo9PZAFou+npiCCDXoiJgYfc2WurSvIujQZeza6Mx2Ga0MWH70WmclGA==","t":"uEty6cTw+m5djarsWuEAZ21fth83lcVLWzXcJvi3ytGAwX9D3xovXzIDZArG39KW5gFpD2L13K1jTb28dYNuVQ=="},{"publicKey":"mMMWZrWPlO5b9IB8vF5kUJW4f7ULH1wuEop3NOYqNW0=","signature":"8uss3TNOMA9Ldsx3JRMACQm1I95spDPuAHD0XA+zanIlJt46FNflH3Q9uC64jRQ7O5rHSbYOJssXR4LvUP5moA==","t":"gOMwdHtr7nVGkReNHVYSXHd73Qpwgy0UelvoSPhDo8tk2tcSFSnhRIOOsOx/Wxnri0IGyrCEqP71zqnKy7JEGw=="},{"publicKey":"mMMWZrWPlO5b9IB8vF5kUJW4f7ULH1wuEop3NOYqNW0=","signature":"wG0LFJo9C4idhfLpV8E4u+UfbuReYTx3dSG75Gv9XXnBWb0zFSeZiYSDeyMl/3vhsePoC18Qd8FLACuxA+BaZA==","t":"c3oGitLOG533th5VbqY4vdEsXjMAeWEGVCrItW0T8PqBPhXB8hp1fXxgUeOn+yn1faDSq8cQ2dAUkdeEc/A/6w=="},{"publicKey":"mMMWZrWPlO5b9IB8vF5kUJW4f7ULH1wuEop3NOYqNW0=","signature":"UbyFka8SmlJO5J9JgQxWJO8WLTBxy60Rtfq4NqFoJsEbzr6R1t1IPHrf1wiJphw4Xu/GLKfGBo+URQxHTV3bYg==","t":"5bn4H3yfuuvyvTqhvkKYfLsTT2LZtNkgofTP8CQkSzTOHxNJyb/vyTgf4XkefNHQZUIW6kZFD0o1LKJ9/y7bZg=="},{"publicKey":"mMMWZrWPlO5b9IB8vF5kUJW4f7ULH1wuEop3NOYqNW0=","signature":"/qdECFm9RBBOWCIVEiTpDWRUxGZak1t4ARg+Z3ftAWnJPuW6V3wEVUE4Vn25GQ05WPQfrbR+5orLKYr2/0nY8w==","t":"qZtcQGOHKVpucMAjvTPd/skwCCgn/TFcWLcSmIyB54tfa0CwlKu//dx/UtJbPdf887uFmw9wSwH4yhoJkRNKbw=="},{"publicKey":"mMMWZrWPlO5b9IB8vF5kUJW4f7ULH1wuEop3NOYqNW0=","signature":"Qp5Qj+6V9DIcfwF99pOE7QB89aUWSZSSxiaFLhvYZqiviqfTvMxuf9fyb1B7BRpw3A0xjCAB9wCzjsf4MrjxiA==","t":"oOVAA1Byks1gzVQaEYWwQZQ1etBhWwFSvTr/t32sDrvxbIsO+2J0oDSYVmouK/6HGxosE4xPmObJkK2JILrsCw=="},{"publicKey":"mMMWZrWPlO5b9IB8vF5kUJW4f7ULH1wuEop3NOYqNW0=","signature":"oVdLf8vx7XWMJwjYXXaaRtxXo+XXJft9Ba5FefYtc4FK4qvxy+Sv9mp/wnFzRsTOqX7aBqXooRMIesRX9/53sA==","t":"BD0GLjeQJ19qpG16tEkZZbYwfYYINrHXwfzOmV93U8wrah3Fg67pexIiBxrU/9Y8Tnp/fur6KEGiktDBZ6yBBg=="},{"publicKey":"mMMWZrWPlO5b9IB8vF5kUJW4f7ULH1wuEop3NOYqNW0=","signature":"PA4yY0+GsDcEQm85RTDOxRuVXMguiOArr0UbXrfal+CSZO5rbUH55hEvj619w8QpM0RFm6vDOlwxkEahnT26Zg==","t":"8D7utVSDq8z9iAW1Qi3gPnDsnLyejfvF9Tf9ALCLsPXbpLcw8pHzPWrEuuUDVMTA1dL0UznP3ELNJHCY88tvyA=="}],"vote":"eyJjaGFubmVsIjoieW91dHViZSNjaGFubmVsOlVDQ3M3QVFFRHdySEVjODZyME5OWEVfQSIsInR5cGUiOiJhdXRvLWNvbnRyaWJ1dGUifQ=="}
> contentType: application/json; charset=utf-8
[ END REQUEST ]
[9045:9045:0615/182110.082101:VERBOSE1:ledger_impl.cc(1020)] 
[ RESPONSE - OnRedeemTokens ]
> time: 1592238070
> result: Success
> http code: 200

2. Anon user funds AC

  • Verified that the AC is successful for multiple verified pubs using restored wallet funds
  • Verified that Recurring and one-time tips are processed
  • Verified AC amount and pubs listed in DB
  • Verified that the Processor value is displayed as 3 in contribution_info table

image
image

> url: http://payment.rewards.bravesoftware.com/v1/votes
> method: UrlMethod::POST
> content: {"credentials":[{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"0Tn+A4XE70XTPB0f9bJtKs8JwCN+yjrhZeQZ8+v0iOCyegLzFVX0vrCjebhCzjDIJGrZyH6KvaLzTW9rqMt3yw==","t":"wf04eIwuxCFPv2l+TOAyu08xtpkgmmb3rcjqoAxhNce+1YTSCg9LlnSo15ggAGfYwZdqbGqrgFIk3jxJCPmb2g=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"fbax9chMCGIajIp6/Nu7jyP2J6RKfE3dAXt+YrnCKVjxVD5isUKlCBAzna0fhmhCAh2SMflo/wgz9cDU1+8bOQ==","t":"2kL8hpE9D2RBxuBacVCY/3atbYOaxDznmtvyb0vZmDOIl9ZoH4ELU5xh+FoQjDMQihBnu8/NEaoW3AqDde7Dhw=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"XyTsWrd5xh/JxkvnUp4rZwIq5GMKT/QQoipGG4r3l5isGGbsnosEdmVgooFH4+XhwwzIQA29tlHt/Y+Qy0X97g==","t":"Kbc6UhcxyOZn3vzRtPjvMX8e0DKNJ0cndXAFVdjh8u7mI6TqKujM4+Cj60e4RV/ZkWc4udPyeZ7iyJ+uAiIOmw=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"4GEoChSccM+Xuj0tRjWp43g1aZQFV/GVZ1b7DjD8IfloDbPlDWNL9Z6QMX52dnleke9925katb5/iMf5v287VQ==","t":"U3xLpi4K/RUHgUf/uXTBMmH9fzyeNTL2rc0xzGGBDuVBVaVTZBX2uTn/38T0Nr2pnzJD9gQEzhWtO8Fe0i2plg=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"mZoUydbB/7KxlsEm+EH9jmcd2j4x5kheDbcdyIq99CUf9NtWiocgrz2lLlcDduSIzjftwlRAaxpGpkiFkUdV+Q==","t":"h0TSJxtEFhQl8M+sujmBhXPC7lUTzmuP2EQ+1RAYv/FrdSe7zNDugztekL/jrA3Wavo7iS+ThrI2k0K9AkhCMQ=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"p8YPVd1WZibxoCppqBf8C2amdMyAIRO8NcwLXWL+lAHZNBpoYfFv1w4Hvc5a9JOBlNweUqjTG8/z86f9CF0riA==","t":"FBk+Sj1vOP9U03lvBk2KmpBMHKgLEVUrnjglyHWYBm3avbODv1D0orEr/GEij5q8BH8s1oN9l97GhVPUq3rEVg=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"mcSvU5cTlwTa2VTf9Eq170SbgB8gK5t4D4VGMKpNLO81PUE4s3+xvO7RDSW9zIVOfWJIw+o4gZ+FxVoIEPkF3g==","t":"vgz//pVpLSGNJGI4P3JbNo7SQl19Z6WBxdTE2K5vKuQD8hu5r29z4LmfnECHDNibknjDxfbXHIP1upVML5yrBg=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"urBd7Z8hopM3uwLZ9ecBE6jCOzevKA26lbWrmu5kzeOeM+09fEg3i0qT5CuDYBjGBSSdszTdyFcK8ssqRW6y0Q==","t":"Ftrz1gnom46GTANeQsex+IY72IWXILI1E3WTklYRl85v3X3e42c3xlKQeuF8v0jVc/MT6vo/eWpeEyv+EPYn7w=="}],"vote":"eyJjaGFubmVsIjoiM3pzaXN0ZW1pLnNpIiwidHlwZSI6ImF1dG8tY29udHJpYnV0ZSJ9"}
> contentType: application/json; charset=utf-8
[ END REQUEST ]
[9679:9679:0615/182956.987470:VERBOSE1:ledger_impl.cc(1020)] 
[ RESPONSE - OnRedeemTokens ]
> time: 1592238596
> result: Success
> http code: 200

3. Anon user funds tips

  • Verified that the one-time tips are processed using restored wallet funds
  • Verified that one time tips can be sent to Twitter, youtube, Reddit and regular verified pubs including custom banner pubs.
  • Verified that tips were recorded in the summary, panel and monthly report

image
image

> url: http://payment.rewards.bravesoftware.com/v1/votes
> method: UrlMethod::POST
> content: {"credentials":[{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"Iu40ijkqsXX8xBLW3KEgdaW0gxNanOwFHv+nYB1kO3PqfMXKtiFxfGnjYsH8HnHmKQodzPI/WVPlZuWAx9sA0w==","t":"fQvnkbyvU8Z6jnbGVPklY/vJXmczoGdyldoMhyeizW5zsLTLsf8hpqWUltw73Yb0W/THGLD2KoCKkYTFpN40qg=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"Lt01fnFIpgdR4WHQ+r+SypjwwWGfPKpJ7XpVjum8l7cZGd0WLbmQv9MN7Wo2rMUX7JQZ46lPCYFB0EWBNVmvhg==","t":"ZdPRJa+Y4Ep+6iVpVNhcJ/sx1bSMN4S02HYCmO9OBzkn3DpZWv6/JA5L+M8hTEBFrRLB+XbEi687hHiRcUZ4JA=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"ZLA80EUvTEkmudm9xBOOOd+d3Wk5xbHrNNSOqjo3qp3U2dgNmpIAilVWOnwj+/SyqL+gxe52+baLJfvBtYO+tw==","t":"LXdH4uCcQxRnKhFtqOjXpleQevhmTWwZKPQbikNAjcVrjupCA+34quvMSTJFq0RspUkbMG/QC146rnzJBWxDlw=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"eT/imXhhR4biUfKG6Dd1miMG5iRM9BhCcxi10rtWaVbXgFMHYzjtTvm1B5S4dZJnf9VdZaWuQAPeO1+CbpQyBQ==","t":"tnxlWHna4LjBZSjJtRBp2HlL5aSWPrVaeFoolyOPEJZXhwPCKGFGxnaLoiIeOvoZ83ctrCiebhtKMcgU36UKlQ=="}],"vote":"eyJjaGFubmVsIjoiM3pzaXN0ZW1pLnNpIiwidHlwZSI6Im9uZW9mZi10aXAifQ=="}
> contentType: application/json; charset=utf-8
[ END REQUEST ]
[10341:10341:0615/183911.029365:VERBOSE1:ledger_impl.cc(1020)] 
[ RESPONSE - OnRedeemTokens ]
> time: 1592239151
> result: Success
> http code: 200

4. Anon user funds Monthly donation

  • Verified that the recurring tips are processed using restored wallet funds
  • Verified that recurring time tips can be sent to Twitter, YT, Reddit and regular verified pubs including custom banner pubs.
  • Verified that recurring tips were recorded in the summary, panel and monthly report

image
image

> url: http://payment.rewards.bravesoftware.com/v1/votes
> method: UrlMethod::POST
> content: {"credentials":[{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"s/2m29Gjqw/MRiFr4dvArYstKkA9UvIJUw5p+rfZXm60eY6vtRFq4v7iqG4jrBn2KS2j8jtRM5O4KJwGm7jaPw==","t":"GYY+9HDaPmQAPp3KTKR7GkrxPVo01wU0z8kf61gsRXsx/wW7St3CgpiMIjxedPn+rNPY5jqv3MgyHlNoJN3hRA=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"MIvANzrneVF15mwGDa7MXUkQVUPCAnQBu6hMHCLg/uw63TZBBc/J+CjDmC2sRZbTOQWrXzG8AgoJ9qPOoVLN8w==","t":"5dIT4aO0qAAsz2nxig6gc+oyeeJ+hlUJznB532alysY74m2dHdg2bLTgIp5hF4AxqEynwMbyk1tXSUEHpBqe2A=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"ChrwD1l7p3SSDn1WYc6VXaK7AWxZijW0xOlLjKtCaO84qAey3kcsd8LwJU9+upiDUu3sWLKXmaWHrO6SXKcHMA==","t":"i1M9fPzui239WrLi7hcrRfgxzXSsxCDl16GnSf6uBGO9paoRqgCLLGeMHgGfrEkTrYuBNMV3YBIzcxkBMhV36A=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"3jRpDQjxkqRnv/pP2w/vybd7UB4NYf11NSFFqzvyiSmhc/YK3j+WS2uo5QhXX6A8URSMq072r4ayV0gAwWWqBw==","t":"EMxAJnA7rnbFxSGmOzfgX3zLTxZZuY2XK8xwa3RsrYmMpFJTnSrvRZO1Hyj0vobkfv/e9MhKqXNa/FWR2s25Dg=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"CwxQ1rAofB3ToOWITZSqlF4mgI6ATWHqGSB4rdngbuW/KIH6FIqv8dZYllFAbYPsCUZsT9tiQqf0BR5FYTqllQ==","t":"QlxAkvxbhYOCZwIOYxrQfufZhq1VNCCuoLiDHtrk8dC9lqXEKR/fCEUWRwG9k9Nep7oUyaujIW7b/rxImGDS2g=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"7/rjNgoSUC/TiwKsPxVhd2uyIoLXMdCTQLBmCuN62x3gVWIbHi9f5+8RjfLNLPCkIuKyXwxSuSi2b05zxCvlfg==","t":"Qq7tGdaltCfbkdKrsE2soZehMOeZvx1wdp/UbMRJNpXSYEB1FV3EJUJrJw+x/Lf6QbkiQPMlnvE2to7mzgp4fg=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"fMAfB10IUyg0aZvs//H4GuGSEchPd5OqaxO1Fjo3jhhjDkMtzwZ4QxEmJrpFXbLk4T5h4w2zFSTlDFv6lgja3g==","t":"H+wQqVWvatAvNf24Y4Tr7RJw4TFE8/NrVdfgYpj11X1+gI8/1U6AAWmIavmfNKgY+VHJm6Ypstoc2PueifefWQ=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"tRObCX+SnO09O9fypY/ztafTBlCVj2jaEchyvSHFJeCutJT8s2tDPsRfrYbDUjP31g2BGppiYMuD4S/ojHlrLw==","t":"noA7SCi0lmKUe+Cb3OFmSuz/8IBzkvIY9E00OgODFZ+6jKMP41VWa6z5e98WxEA4XPH6W3xUBFzyzWZGqVBn7w=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"zwM3ewjlRrSgdPoSB621EpADLRORVlhPNJtXcRQhQ07qA7cXGUj8pUjFiQEtLAfZ/DQBntg4iQB/kCDFWD3ySA==","t":"twVpbCXJ0Q+G1U2k1Z7LMxjr0b/XTChnlv6bq+YSwbwtVz1IeHzXwr2iT3GH4pzbd8RoK6Deki4oc7L4+nP49g=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"IupDJQY2CBD32rDTHDpZ9WC48ktoQ5cm87MeZuFqm/82ehxn59Y+3SbH9ltiITaK7dNlODO0zEPBEE3YODf0rw==","t":"vLR+pSLk/OnyZl53y0GcMHwq60msRjEaDQd1x/YXHV6lmBKAAAozIHQD2rQgzwQjz++OXyLjHxUKUKGQrAFzhg=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"rWGPhwqXd3QbzcnCA5ywwSgo7q1vSHyJIa2cgfM1QCOk1EPkP3XSO+BuKyJrQRoXv17/uRBkwIlHIFGj3gwqUg==","t":"ZnwMMlFmH5whYW1nf8y2Lg3s/uQZA4uq5MPUSbVv4gCweQZ/ckWlpNknyLWI5+qiMUMPKuEp6+oQBIH886AiRw=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"TtMmKSt9D0kpxRhGsTfzQ+ElD3/ZT/tf+n3ODM8BKMjWuJwoYNWJfTJwyaxw/ieDm5391MsF6B7nZENl20yvNQ==","t":"HMjZpFXzdYG63vzeYgNahXlligMRB3bpEte1UTajKSkV2MPDTTWr0Jc9TC0YGW2A0Kvim7b10xCm4863wR4kPQ=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"T/sDLTo2FrByguHoE5IpyDa7xavJaIAcc+nWcreLAyd99GR5W5x01VYhc/9fd26gSN+euLzMmA225HnjtfY8iA==","t":"Ub+qs5SMDpjJdo0/0/yTt9yedFn7HmcGmz8ljDwKPFnG3//ezBYYLShRlMSrJhkE1UZpne0c+01chHw/M+oOLw=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"XQl7i33PFvZeQRcm1mGRP0cGLJNG+S4z2iHqFNFligI5M5cFKAuwSasbd1z5TFVRAEeXoBK2CUElLaJMLWKd5Q==","t":"S/ZDjHzIYObvE4olh0if4JMu8GboVAerzz+6DSbkvmfS+310LkX1J0dJdqnocg8pmEFQKHhnq86nc3KBwzyUog=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"U9165YDjxrBexQLM1X0SJUU/0HesK5P7Mo2VrCxHsOo+DmOxDSx6tGukXBlBSmsBi/DA7e1qp9pdJocEeXuRCA==","t":"O0U56ZE/n+07onmflc0iPmbln0eAmOShChlzrXXQjWSrAS3BCTURkGyIkj15kLr0iv8yZwCP5JusBUFirk0XHA=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"wxqL8vqkL+euC7Ujqlq4QvVfXy5wuM4woyKEV+sl9ogwBhISFdGTG6RnzawoG5bRtZODd6Y0k4kfHikgwxqsqg==","t":"JBTMjUlJyehvVqWkJum/boJd3GN/olFgMzO7TJV7a8ldOP3SpO5YpV5IqgJIL3w07hB9LA4r9kMv3GAIfinD0g=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"G0a2562nsTpVOTylJ7p+3vrtTsjeaMB+jtQWyDxeNGXVCSrhn3x68IeizdwaHUxrwYOxmMlLtwmDA4s9DQPcdg==","t":"x/asi3c+yUVkm94dgV3ExKsqTPC/ZUW5fPpNGXYNbSB8TBnk0nUYJ8W0UNjo75GxfnB85V2do3CcEva4kXjnzg=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"rXVRQXYFyiG0REqkG67V73c+jdorwpgN2QVYE0hGWCJniksxnOSLKgN+gxSX3tiQ7t49Eebu/smBgLOzXgDtow==","t":"OdIEGlsNy+sIFZ55JTTfeDB9IAcEbXj+W13F5rejPwtANiHGrEvIut4AU2Skc1+8tpuB6/zCjZpbMz8HWwAlZg=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"U3MxSnIPApNJkdAhvMfP/ZMi62Dsr1xucLCF2PkAW3hPBsfZgHh7VBDA+wnnvK2yH5t5QzQ031LKuJXAlnAt2g==","t":"sNY4BnDC1/P+Acb/SxRXLrcWmPCcUDsLD7CP/3mAwppy1w52FCEBD0PefgczJ5VFMd7s18DOruOEVwnLkjv84Q=="},{"publicKey":"CMezK92X5wmYHVYpr22QhNsTTq6trA/N9Alw+4cKyUY=","signature":"Upp4hd7pzp5lowBkivWS+xqdty/6F2rr4uPNSstBjdltcqRkHdzTwigFv4mMzSnwfVXaJ/LLx0VHl2A2OFWBKA==","t":"8ZhTBDZoWfiLxDqJKER5SoUbfqGYTLT1KDJ8tX9G9+7CjFlNCbHt6jaY+PjromkuFWoQkNmZZwCcyHmBfE4fxg=="}],"vote":"eyJjaGFubmVsIjoidHdpdHRlciNjaGFubmVsOjg3MDM5MDcyODYwMTUwMTY5NiIsInR5cGUiOiJyZWN1cnJpbmctdGlwIn0="}
> contentType: application/json; charset=utf-8
[ END REQUEST ]
[11040:11040:0615/185245.041867:VERBOSE1:ledger_impl.cc(1020)] 
[ RESPONSE - OnRedeemTokens ]
> time: 1592239965
> result: Success
> http code: 200

@LaurenWags
Copy link
Member

Verified the following cases using below build and staging env:

Brave	1.10.82 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
Revision	8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS	macOS Version 10.14.6 (Build 18G3020)

Uphold AC SKU TCs (single funding source)

VG only (ex. UGP grant):

  1. [PASS] Verify a one time tip only can be performed using a wallet funded only with virtual grants.
  2. [PASS] Verify a monthly recurring contribution only can be performed using a wallet funded only with virtual grants. Note - AC was not explicitly toggled off with this check, but the list was empty prior to reconcile. AC toggled off was checked via monthly contributions contributing again after browser restart when AC is disabled #10006.
  3. [PASS] Verify a one time tip and a monthly recurring contribution can be performed using a wallet funded only with virtual grants. Note - AC was not explicitly toggled off with this check, but the list was empty prior to reconcile.

User Funds only (restored wallet funded anonymously from when this was allowed in UI):

  1. [PASS] Verify a one time tip only can be performed using a wallet funded only with user funds.
  2. [PASS] Verify a monthly recurring contribution only can be performed using a wallet funded only with user funds. Note - AC was not explicitly toggled off with this check, but the list was empty prior to reconcile.
  3. [PASS] Verify a one time tip and a monthly recurring contribution can be performed using a wallet funded only with user funds. Note - AC was not explicitly toggled off with this check, but the list was empty prior to reconcile.

Uphold only (KYC'd user wallet):

  1. [PASS] Verify a one time tip only can be performed using a KYC'd user wallet funded only with BAT from Uphold

Verified the following cases using below build and staging env:

Brave	1.10.86 Chromium: 83.0.4103.61 (Official Build) (64-bit)
Revision	94f915a8d7c408b09cc7352161ad592299f384d2-refs/branch-heads/4103@{#561}
OS	macOS Version 10.14.6 (Build 18G3020)

Uphold only (KYC'd user wallet):

  1. [PASS] Verify a monthly recurring contribution only can be performed using a KYC'd user wallet funded only with BAT from Uphold
  2. [PASS] Verify a one time tip and a monthly recurring contribution can be performed using a KYC'd user wallet funded only with BAT from Uphold

Verified the following cases using below build and staging env:

Brave	1.10.88 Chromium: 83.0.4103.97 (Official Build) (64-bit)
Revision	326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS	macOS Version 10.14.6 (Build 18G3020)

VG only (ex. UGP grant):

  1. [PASS] Verify auto contribute only can be performed using a wallet funded only with virtual grants. Restart the browser, confirm nothing contributes unexpectedly.
  2. [PASS] Verify a one time tip and auto contribute can be performed using a wallet funded only with virtual grants. Restart the browser, confirm nothing contributes unexpectedly.
  3. [PASS] Verify a monthly recurring contribution and auto contribute can be performed using a wallet funded only with virtual grants. Restart the browser, confirm nothing contributes unexpectedly.
  4. [PASS] Verify a one time tip, a monthly recurring contribution, and auto contribute can be performed using a wallet funded only with virtual grants. Restart the browser, confirm nothing contributes unexpectedly.

User Funds only (restored wallet funded anonymously):

  1. [PASS] Verify auto contribute only can be performed using a wallet funded only with user funds. Restart the browser, confirm nothing contributes unexpectedly.
  2. [PASS] Verify a one time tip and auto contribute can be performed using a wallet funded only with user funds. Restart the browser, confirm nothing contributes unexpectedly.
  3. [PASS] Verify a monthly recurring contribution and auto contribute can be performed using a wallet funded only with user funds. Restart the browser, confirm nothing contributes unexpectedly.
  4. [PASS] Verify a one time tip, a monthly recurring contribution, and auto contribute can be performed using a wallet funded only with user funds. Restart the browser, confirm nothing contributes unexpectedly.

Uphold only (KYC'd user wallet):

  1. [PASS] Verify auto contribute only can be performed using a KYC'd user wallet funded only with BAT from Uphold
  2. [PASS] Verify a one time tip and auto contribute can be performed using a KYC'd user wallet funded only with BAT from Uphold
  3. [PASS] Verify a monthly recurring contribution and auto contribute can be performed using a KYC'd user wallet funded only with BAT from Uphold. Restart the browser, confirm nothing contributes unexpectedly.
  4. [PASS] Verify a one time tip, a monthly recurring contribution, and auto contribute can be performed using a KYC'd user wallet funded only with BAT from Uphold. Restart the browser, confirm nothing contributes unexpectedly.

VG/User Funds Split:

  1. [PASS] Have a wallet with VG BAT and BAT from a restored user wallet. Set AC budget so all VG will be used and remaining amount will come from user funds. Perform AC and confirm it is completed as expected without errors. Verify this is displayed in monthly statement and sources for BAT are correct.
  2. [PASS] Have a wallet with VG BAT and BAT from a restored user wallet. Tip a verified publisher so that all VG will be used and remaining amount will come from user funds. Confirm tip is completed as expected without errors. Verify this is displayed in monthly statement. Restart browser. Confirm nothing is contributed unexpectedly.
  3. [PASS] Have a wallet with VG BAT and BAT from a restored user wallet. Set up a monthly contribution to a verified publisher so that all VG will be used and remaining amount will come from user funds. Confirm monthly contribution is completed as expected without errors. Verify this is displayed in monthly statement. Restart browser. Confirm nothing is contributed unexpectedly.

User Funds/Uphold Split:

  1. [FAIL - [Desktop] AC split between anon wallet and Uphold wallet does not contribute correctly #10224] Have a KYC'd Uphold user wallet and BAT from a restored user wallet. Set AC budget so all restored BAT will be used and remaining amount will come from KYC'd wallet. Perform AC and confirm it is completed as expected without errors. Verify this is displayed in monthly statement. Restart the browser, confirm nothing contributes unexpectedly.

VG/Uphold Split

  1. [PASS] Have a KYC'd Uphold user wallet and VG BAT. Set AC budget so all VG BAT will be used and remaining amount will come from KYC'd wallet. Perform AC and confirm it is completed as expected without errors. Verify this is displayed in monthly statement and sources for BAT are correct. Restart the browser, confirm nothing contributes unexpectedly.
  2. [PASS] Have a KYC'd Uphold user wallet and VG BAT. Tip a KYC'd publisher so that all VG BAT will be used and remaining amount will come from KYC'd wallet. Confirm tip is completed as expected without errors. Verify this is displayed in monthly statement. Restart the browser, confirm nothing contributes unexpectedly.
  3. [PASS] Have a KYC'd Uphold user wallet and VG BAT. Set up a monthly contribution to a KYC'd publisher so that all VG BAT will be used and remaining amount will come from KYC'd wallet. Confirm monthly contribution is completed as expected without errors. Verify this is displayed in monthly statement. Restart the browser, confirm nothing contributes unexpectedly.

Verified the following cases using below build and staging env:

Brave	1.10.90 Chromium: 83.0.4103.97 (Official Build) (64-bit)
Revision	326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS	macOS Version 10.14.6 (Build 18G3020)
  • Verified test plan from Implementation of SKU system brave-core#4869
  • For each scenario in the test plan,
    • Confirmed AC, recurring, and one time tips were contributed as expected
    • Confirmed they displayed in the UI as expected (summary panel and Monthly Summary)
    • Confirmed there were calls to /v1/votes in the logs as expected

Note - the following test cases were skipped due to internal discussions (low use case scenarios, can revisit these as needed): https://bravesoftware.slack.com/archives/C7VLGSR55/p1591893693140700?thread_ts=1591889666.135600&cid=C7VLGSR55

User Funds/Uphold Split:

  1. [SKIPPED] Have a KYC'd Uphold user wallet and BAT from a restored user wallet. Tip a KYC'd publisher so that all restored BAT will be used and remaining amount will come from KYC'd wallet. Confirm tip is completed as expected without errors. Restart the browser, confirm nothing contributes unexpectedly.
  2. [SKIPPED] Have a KYC'd Uphold user wallet and BAT from a restored user wallet. Set up a monthly contribution to a KYC'd publisher so that all restored BAT will be used and remaining amount will come from KYC'd wallet. Confirm monthly contribution is completed as expected without errors. Restart the browser, confirm nothing contributes unexpectedly.

VG/User Funds/Uphold Split

  1. [SKIPPED] Have a wallet with 20 BAT from VG, 20 BAT from a restored user wallet, and 10 BAT from KYC'd Uphold user wallet (total 50 BAT). Set AC to 50 BAT. Perform AC and confirm it is completed as expected without errors. Verify this is displayed in monthly statement and sources for BAT are correct.
  2. [SKIPPED] Have a wallet with 20 BAT from VG, 20 BAT from a restored user wallet, and 10 BAT from KYC'd Uphold user wallet (total 50 BAT). Tip a KYC'd publisher 50 BAT. Confirm tip is completed as expected without errors. Verify this is displayed in monthly statement.
  3. [SKIPPED] Have a wallet with 20 BAT from VG, 20 BAT from a restored user wallet, and 10 BAT from KYC'd Uphold user wallet (total 50 BAT). Do a monthly contribution to a KYC'd publisher for 50 BAT. Confirm monthly contribution is completed as expected without errors. Verify this is displayed in monthly statement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants