-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AC with virtual grants flow with uphold funds #7595
Comments
@NejcZdovc does this issue also cover the AC notification on the BAT logo? Meaning, if I do an auto contribute with an Uphold KYC'd wallet using 1.3.97, the AC appears to go thru (my wallet balance is decreased), but I don't get a notification on my BAT logo. |
@LaurenWags this is a separate issue. Can you please double check if everything is ok on 1.2? Please log if you can reproduce this. Thank you |
Does not reproduce in 1.2.x. Additionally, found a second scenario in which there's no AC notification. Logged #7836 to cover both cases. If they should be separate lmk - happy to log another issue if needed. |
Is this one confirmed to fix the Bat Ledger Service CPU issue, or do we need to wait for brave/brave-core#5568 as suggested in #8846? |
This issue will be tested once #10058 is fixed, as AC needs to be tested with multiple publishers. |
Verification passed on
1. Uphold funds AC
2. Anon user funds AC
3. Anon user funds tips
4. Anon user funds Monthly donation
Note: In this scenario AC is also triggered along with recurring tips.
Verification passed on
1. Uphold funds AC
2. Anon user funds AC
3. Anon user funds tips
4. Anon user funds Monthly donation
|
Verified the following cases using below build and staging env:
Uphold AC SKU TCs (single funding source)VG only (ex. UGP grant):
User Funds only (restored wallet funded anonymously from when this was allowed in UI):
Uphold only (KYC'd user wallet):
Verified the following cases using below build and staging env:
Uphold only (KYC'd user wallet):
Verified the following cases using below build and staging env:
VG only (ex. UGP grant):
User Funds only (restored wallet funded anonymously):
Uphold only (KYC'd user wallet):
VG/User Funds Split:
User Funds/Uphold Split:
VG/Uphold Split
Verified the following cases using below build and staging env:
Note - the following test cases were skipped due to internal discussions (low use case scenarios, can revisit these as needed): https://bravesoftware.slack.com/archives/C7VLGSR55/p1591893693140700?thread_ts=1591889666.135600&cid=C7VLGSR55 User Funds/Uphold Split:
VG/User Funds/Uphold Split
|
If user has user funds (uphold) we need to have a way to covert this BAT into unblinded tokens. We will be using new SKU flow to accommodate that.
The text was updated successfully, but these errors were encountered: