-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not generate dummy originator_cache_guid
and random originator_client_item_id
in GetUpdatesResponse
#4623
Conversation
059339c
to
e098083
Compare
…client_item_id` in GetUpdatesResponse to prevent ReplaceBookmarkNodeGUID from triggering for every updates. We will see "Update is missing requirements for bookmark position." error in debug build though but it is ok because we currently don't rely on UniquePosition to decide bookmark position. And we don't propagate correct value of these two ids between devices.
e098083
to
3356c7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
I verified test plan for this PR, but I couldn't see the crash with the same steps on master
I have no STR to reproduce the crash but this is to prevent unnecessary calling |
CI failed at Not related to this PR |
Verified using
Device A: Verification passed on
Both Devices: Ubuntu 18.04 LTS |
to prevent ReplaceBookmarkNodeGUID from triggering for every updates.
We will see "Update is missing requirements for bookmark position."
error in debug build though but it is ok because we currently don't
rely on UniquePosition to decide bookmark position. And we don't
propagate correct value of these two ids between devices.
Resolves brave/brave-browser#8228
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
about:flags#brave-sync
to enable it on device A and device BReviewer Checklist:
After-merge Checklist:
changes has landed on.