Crash on ReplaceBookmarkNodeGUID

[darkdh]

Description

https://stats.brave.com/dashboard#crash/5e442bd5e3ac94006ab195ee

Steps to Reproduce

N/A

Actual result:

0  chrome.dll!bookmarks::UrlIndex::RemoveImpl(bookmarks::BookmarkNode *,std::__1::set,std::__1::allocator > *) [url_index.cc : 134 + 0xc]
    rax = 0x000001e1d1514170   rdx = 0x00000000000001a4
    rcx = 0x00000000000001a4   rbx = 0x000001e1d1113110
    rsi = 0x00000099157fe8b8   rdi = 0x000001e1d11130f0
    rbp = 0x0000000000000008   rsp = 0x00000099157fe760
     r8 = 0x0000000000000057    r9 = 0x0000000000000002
    r10 = 0x0000000000000008   r11 = 0x0000000000000008
    r12 = 0x00000099157fe8b8   r13 = 0x000001e1d1514170
    r14 = 0x000001e1d1113108   r15 = 0x00000099157fe788
    rip = 0x00007ffd6d5e6b76
    Found by: given as instruction pointer in context
 1  chrome.dll!base::internal::LockImpl::Lock() [lock_impl_win.cc : 37 + 0x15]
    rsp = 0x00000099157fe780   rip = 0x00007ffd6a0163b7
    Found by: stack scanning
 2  chrome.dll!bookmarks::UrlIndex::Remove(bookmarks::BookmarkNode *,std::__1::set,std::__1::allocator > *) [url_index.cc : 29 + 0xe]
    rsp = 0x00000099157fe7e0   rip = 0x00007ffd6d5e69bb
    Found by: stack scanning
 3  chrome.dll!base::EraseIf,`lambda at ../..\base/observer_list.h:329:25'> [stl_util.h : 546 + 0xd]
    rsp = 0x00000099157fe7f0   rip = 0x00007ffd6a9abb64
    Found by: stack scanning
 4  chrome.dll!bookmarks::BookmarkModel::Remove(bookmarks::BookmarkNode const *) [bookmark_model.cc : 232 + 0xb]
    rsp = 0x00000099157fe870   rip = 0x00007ffd6cceb5c4
    Found by: stack scanning
 5  chrome.dll!std::__1::__tree,std::__1::allocator >,std::__1::unique_ptr > >,std::__1::__map_value_compare,std::__1::allocator >,std::__1::__value_type,std::__1::allocator >,std::__1::unique_ptr > >,std::__1::less,std::__1::allocator > >,1>,std::__1::allocator,std::__1::allocator >,std::__1::unique_ptr > > > >::erase(std::__1::__tree_const_iterator,std::__1::allocator >,std::__1::unique_ptr > >,std::__1::__tree_node,std::__1::allocator >,std::__1::unique_ptr > >,void *> *,__int64>) [__tree : 2521 + 0x8]
    rsp = 0x00000099157fe8a0   rip = 0x00007ffd6ebf8c9e
    Found by: stack scanning
 6  chrome.dll!sync_bookmarks::BookmarkRemoteUpdatesHandler::Process(std::__1::vector >,std::__1::allocator > > > const &,bool) [bookmark_remote_updates_handler.cc : 249 + 0xc]
    rsp = 0x00000099157fe990   rip = 0x00007ffd6ebf921a
    Found by: stack scanning
 7  chrome.dll!sync_bookmarks::BookmarkModelTypeProcessor::OnUpdateReceived(sync_pb::ModelTypeState const &,std::__1::vector >,std::__1::allocator > > >) [bookmark_model_type_processor.cc : 259 + 0x10]
    rsp = 0x00000099157fea80   rip = 0x00007ffd6ddce500
    Found by: stack scanning
...

Expected result:

No crash

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

• Can you reproduce this issue with the current release?
• Can you reproduce this issue with the beta channel?
• Can you reproduce this issue with the dev channel?
• Can you reproduce this issue with the nightly channel?

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

[GeetaSarvadnya]

Verification passed on

Brave	1.3.116 Chromium: 80.0.3987.106 (Official Build) (64-bit)
Revision	f68069574609230cf9b635cd784cfb1bf81bb53a-refs/branch-heads/3987@{#882}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

• Verified the test plan from Do not generate dummy originator_cache_guid and random originator_client_item_id in GetUpdatesResponse brave-core#4623
• No crash and no error logs in the console
  

---

Verification passed on

Brave	1.3.116 Chromium: 80.0.3987.106 (Official Build) (64-bit)
Revision	f68069574609230cf9b635cd784cfb1bf81bb53a-refs/branch-heads/3987@{#882}
OS	Linux

• Verified the test plan from Do not generate dummy originator_cache_guid and random originator_client_item_id in GetUpdatesResponse brave-core#4623
• No crash and no error logs in the console
• Bookmark reorder on device B
  
• After bookmark reorder on device A
  

Verified passed with

Brave	1.3.116 Chromium: 80.0.3987.106 (Official Build) (64-bit)
Revision	f68069574609230cf9b635cd784cfb1bf81bb53a-refs/branch-heads/3987@{#882}
OS	macOS Version 10.14.6 (Build 18G3020)

• Verified test plan from Do not generate dummy originator_cache_guid and random originator_client_item_id in GetUpdatesResponse brave-core#4623
• Verified moving both A1 and A2 (separately), no crashes observed on either device