-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash when brave action button is clicked with extension-toolbar-menu (uplift to 1.1.x) #4096
Conversation
Restarting
|
Restarting |
@simonhong @bsclifton mind taking a look at this one? Looks like it keeps failing on |
f9c387c
to
453fde1
Compare
Hmm, errors seems not related with this PR. |
@kjozwiak Passed 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uplift into 1.1.x
denied after deliberating with @brave/uplift-approvers. Because this only happens if a user enables extensions-toolbar-menu
via brave://flags
, it only affects a small percentage of users. Because it's a feature that we currently don't support, we can just allow this to ride the trains. If Chromium decides to enable this by default, we can revisit if it hasn't made it into the Release
channel.
After speaking with @bsclifton, going to label brave/brave-browser#5646 as P3
instead of P2
.
Uplift of #4065
Fixes brave/brave-browser#5646
Approved, please ensure that before merging:
After you merge: