Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when brave action button is clicked with extension-toolbar-menu (uplift to 1.1.x) #4096

Closed
wants to merge 1 commit into from

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Nov 28, 2019

Uplift of #4065
Fixes brave/brave-browser#5646

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Nov 28, 2019
@brave-builds brave-builds added this to the 1.1.x - Beta milestone Nov 28, 2019
@bsclifton bsclifton requested review from a team and removed request for bbondy, kjozwiak, bsclifton, rebron and srirambv November 28, 2019 05:35
@kjozwiak
Copy link
Member

Restarting macOS due to https://ci.brave.com/job/brave-browser-build-pr/job/pr4065_fix-5646_1.1.x/1/execution/node/673/log/:

02:47:49  [43376:775:1128/024715.703404:ERROR:notifications.cc(289)] Failed to load notifications state, resetting to default values
02:47:49  [43376:775:1128/024715.842866:ERROR:ads_serve.cc(89)] Failed to download catalog from:
02:47:49    url: https://ads-serve.brave.com/v1/catalog
02:47:49    response_status_code: -1
02:47:49    response: 
02:47:49    headers: 
02:47:49  [43370:775:1128/024717.367905:ERROR:brave_referrals_service.cc(213)] Failed to fetch headers from referral server, error: -102, response code: -1, payload: , url: https://laptop-updates.brave.com/promo/custom-headers
02:47:49  [43370:775:1128/024717.368229:ERROR:brave_referrals_service.cc(241)] Failed to initialize referral, error: -102, response code: -1, payload: , url: https://laptop-updates.brave.com/promo/initialize/nonua
02:47:49  ../../brave/components/brave_rewards/browser/rewards_service_browsertest.cc:918: Failure
02:47:49  Expected: (js_result.ExtractString().find("" + amount_str + ".0 BAT")) != (std::string::npos), actual: 18446744073709551615 vs 18446744073709551615

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Nov 28, 2019
@kjozwiak
Copy link
Member

@kjozwiak
Copy link
Member

kjozwiak commented Dec 2, 2019

@simonhong @bsclifton mind taking a look at this one? Looks like it keeps failing on macOS at the same spot. #4095 passed without any issues under 1.2.x after a restart.

@simonhong simonhong force-pushed the pr4065_fix-5646_1.1.x branch from f9c387c to 453fde1 Compare December 2, 2019 07:36
@simonhong
Copy link
Member

Hmm, errors seems not related with this PR.
Rebased onto latest 1.1.x and restarted.

@simonhong
Copy link
Member

@kjozwiak Passed 🎉

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.1.x denied after deliberating with @brave/uplift-approvers. Because this only happens if a user enables extensions-toolbar-menu via brave://flags, it only affects a small percentage of users. Because it's a feature that we currently don't support, we can just allow this to ride the trains. If Chromium decides to enable this by default, we can revisit if it hasn't made it into the Release channel.

After speaking with @bsclifton, going to label brave/brave-browser#5646 as P3 instead of P2.

@kjozwiak kjozwiak closed this Dec 2, 2019
@kjozwiak kjozwiak deleted the pr4065_fix-5646_1.1.x branch December 2, 2019 19:29
@kjozwiak kjozwiak removed this from the 1.1.x - Beta milestone Dec 2, 2019
@kjozwiak kjozwiak removed CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS labels Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants