Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when clicking on the Brave or Brave Rewards icons with extensions-toolbar-menu enabled #5646

Closed
mcamou opened this issue Aug 13, 2019 · 16 comments · Fixed by brave/brave-core#4065

Comments

@mcamou
Copy link

mcamou commented Aug 13, 2019

Test plan

See brave/brave-core#4065

Description

Brave crashes whenever I click on the Brave or Brave Rewards icons on the address bar. brave://crashes is empty.

Steps to Reproduce

  1. Open Brave
  2. Click on the Brave or Brave Rewards icon

Actual result:

Brave crashes

Expected result:

Brave should not crash. The proper dialog (either the Shields dialog or the Brave Rewards dialog, depending on which icon was clicked) should show up.

Reproduces how often:

Happens every time

Brave version (brave://version info)

Brave: 0.67.124 Chromium: 76.0.3809.100 (Official Build) (64-bit)
Revision: ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS: Linux
Window manager: KDE Plasma 5.16.4-0ubuntu1

$ lsb_release -a
LSB Version:    core-10.2019031300ubuntu1-noarch:printing-10.2019031300ubuntu1-noarch:security-10.2019031300ubuntu1-noarch
Distributor ID: Ubuntu
Description:    Ubuntu 19.04
Release:        19.04
Codename:       disco
You                                                                                                                                                            

$ uname -a
Linux tumbolia 5.0.0-23-generic #24-Ubuntu SMP Mon Jul 29 15:36:44 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Version/Channel Information:

I have not tried it on any other channels. However, it happened on the previous version I got from the https://brave-browser-apt-release.s3.brave.com PPA, possibly on even earlier versions, but I haven't been keeping track of how often it is updated. It has been happening for a few weeks now.

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?

I cannot disable Brave Shields due to this issue

  • Does the issue resolve itself when disabling Brave Rewards?

I cannot disable Brave Rewards due to this issue

  • Is the issue reproducible on the latest version of Chrome?

Does not apply to Chrome, this is Brave-specific functionality

Miscellaneous Information:

@NejcZdovc NejcZdovc added feature/rewards feature/shields The overall Shields feature in Brave. labels Aug 19, 2019
@NejcZdovc
Copy link
Contributor

@mcamou could you please send us crash ID from chrome://crashes/ (note that you need to upload it first). Thank you

@mcamou
Copy link
Author

mcamou commented Aug 22, 2019 via email

@NejcZdovc
Copy link
Contributor

@mcamou just want to be double sure. When you say browser crashes, you mean that panel (from clicking on BAT logo) is blank or browser is closed?

@mcamou
Copy link
Author

mcamou commented Aug 22, 2019

The browser closes completely and when restarting I get the "reopen tabs" dialog. I just did it now and restarted the browser. Here's the screenshot from brave://crashes:
image

@mcamou
Copy link
Author

mcamou commented Aug 22, 2019

Right now I just started it up from the terminal and made it crash. Here's the complete stdout:

$ brave-browser
[22509:22509:0822/091356.165122:ERROR:sandbox_linux.cc(369)] InitializeSandbox() called with multiple threads in process gpu-process.
[22509:22509:0822/091356.358689:ERROR:buffer_manager.cc(488)] [.DisplayCompositor]GL ERROR :GL_INVALID_OPERATION : glBufferData: <- error from previous GL command
[1]    22477 segmentation fault (core dumped)  brave-browser

The two first lines come up when the browser starts, then when I clicked on the Brave Rewards icon I just got the core dump message.

@mcamou
Copy link
Author

mcamou commented Aug 23, 2019

While this is diagnosed and hopefully fixed... is there a workaround to turn Shields on/off for specific domains without using the normal Shields popup?

@mcamou
Copy link
Author

mcamou commented Aug 26, 2019

One more data point: I just realized that at some point I had enabled the chrome://flags/#extensions-toolbar-menu flag. I disabled it and now the Brave Rewards and Shields popups work correctly, so the issue is related to that.

@NejcZdovc
Copy link
Contributor

@mcamou thank you very much for this details, we will investigate

@NejcZdovc NejcZdovc added feature/extensions and removed feature/rewards feature/shields The overall Shields feature in Brave. labels Aug 26, 2019
@kjozwiak kjozwiak added bug crash workaround/flags resolve by flipping brave://flags and removed OS/Linux labels Aug 27, 2019
@kjozwiak
Copy link
Member

kjozwiak commented Aug 27, 2019

Reproduced on both macOS 10.14.6 and Win 10 x64 using the following build:

Brave 0.68.131 Chromium: 76.0.3809.100 (Official Build) (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}

STR:

  • launch 0.68.131 Chromium: 76.0.3809.100
  • enable extensions-toolbar-menu via brave://flags (restart the browser)
  • visit https://www.brave.com and click on the shields panel

You'll receive an instant crash as described by @mcamou.

@rebron
Copy link
Collaborator

rebron commented Aug 27, 2019

cc: @petemill and @bradleyrichter to put on your radar, another issue with Extensions menu icon.

@Brave-Matt
Copy link

I can confirm and reproduce that, when the #extensions-toolbar-menu flag is enabled, attempting to access either Shields or Rewards via icon in address bar will crash the browser. I have a +1 here and will drop in others i've seen:
https://community.brave.com/t/pressing-the-shield-button-crashes-brave/81943/3

@NejcZdovc
Copy link
Contributor

+1 from #5619

@srirambv
Copy link
Contributor

srirambv commented Oct 5, 2019

Here's a crash report for investigation https://stats.brave.com/dashboard#crash/5d9898980a9f46001fbeccab

@Mhowser
Copy link

Mhowser commented Oct 12, 2019

I have the same crash when the aforementioned flag is enabled. Zorin OS 15 with latest stable version.
image

@bsclifton bsclifton changed the title Brave crashes when clicking on the Brave or Brave Rewards icons Crash when clicking on the Brave or Brave Rewards icons with extensions-toolbar-menu enabled Nov 5, 2019
@jmkd3v
Copy link

jmkd3v commented Nov 8, 2019

Same error when chrome://flags/#extensions-toolbar-menu is enabled

@btlechowski
Copy link

btlechowski commented Jan 3, 2020

Verification passed on

Brave 1.3.81 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#4065
Tested on Brave Shields button and Rewards button.

Verification passed on

Brave 1.3.85 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verified passed with

Brave 1.3.86 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS macOS Version 10.14.6 (Build 18G103)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment