-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash when clicking on the Brave or Brave Rewards icons with extensions-toolbar-menu
enabled
#5646
Comments
@mcamou could you please send us crash ID from chrome://crashes/ (note that you need to upload it first). Thank you |
As mentioned in the issue, brave://crashes is empty (no crash information).
|
@mcamou just want to be double sure. When you say browser crashes, you mean that panel (from clicking on BAT logo) is blank or browser is closed? |
Right now I just started it up from the terminal and made it crash. Here's the complete stdout:
The two first lines come up when the browser starts, then when I clicked on the Brave Rewards icon I just got the core dump message. |
While this is diagnosed and hopefully fixed... is there a workaround to turn Shields on/off for specific domains without using the normal Shields popup? |
One more data point: I just realized that at some point I had enabled the |
@mcamou thank you very much for this details, we will investigate |
Reproduced on both
STR:
You'll receive an instant crash as described by @mcamou. |
cc: @petemill and @bradleyrichter to put on your radar, another issue with Extensions menu icon. |
I can confirm and reproduce that, when the |
+1 from #5619 |
Here's a crash report for investigation https://stats.brave.com/dashboard#crash/5d9898980a9f46001fbeccab |
extensions-toolbar-menu
enabled
Same error when |
Verification passed on
Verified test plan from brave/brave-core#4065 Verification passed on
Verified passed with
|
Test plan
See brave/brave-core#4065
Description
Brave crashes whenever I click on the Brave or Brave Rewards icons on the address bar.
brave://crashes
is empty.Steps to Reproduce
Actual result:
Brave crashes
Expected result:
Brave should not crash. The proper dialog (either the Shields dialog or the Brave Rewards dialog, depending on which icon was clicked) should show up.
Reproduces how often:
Happens every time
Brave version (brave://version info)
Brave: 0.67.124 Chromium: 76.0.3809.100 (Official Build) (64-bit)
Revision: ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS: Linux
Window manager: KDE Plasma 5.16.4-0ubuntu1
Version/Channel Information:
I have not tried it on any other channels. However, it happened on the previous version I got from the https://brave-browser-apt-release.s3.brave.com PPA, possibly on even earlier versions, but I haven't been keeping track of how often it is updated. It has been happening for a few weeks now.
Other Additional Information:
I cannot disable Brave Shields due to this issue
I cannot disable Brave Rewards due to this issue
Does not apply to Chrome, this is Brave-specific functionality
Miscellaneous Information:
The text was updated successfully, but these errors were encountered: