-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configurable default tip amounts #3848
Conversation
24c13d0
to
2a099dd
Compare
Failed pipeline steps are the network audit test, which appears to be filed as brave/brave-browser#6189. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you confirm that we don't need a migration path on upgrade for new wallet properties? (For the client side, in case the now non-optional default tip choices wallet property is not immediately present)
2a099dd
to
0d0ab56
Compare
We do not, and I've just added a unit test for this. |
content::WebContents* site_banner) { | ||
auto options = content::EvalJs( | ||
site_banner, | ||
R"( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prefix(optional) R "delimiter( raw_characters )delimiter" (6) (since C++11)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0d0ab56
to
52d40bd
Compare
Issue with default not being pre-selected noticed by @NejcZdovc was fixed. |
components/brave_rewards/resources/ui/components/donate/index.tsx
Outdated
Show resolved
Hide resolved
18d8d3a
to
f0893ef
Compare
@jhoneycutt @NejcZdovc can we unblock the merge and get in to Master? |
309fb6a
to
0261f35
Compare
0261f35
to
2e8da9a
Compare
e4dee37
to
f1bcf3e
Compare
f1bcf3e
to
a7054be
Compare
Went through the STR/Cases outlined under #3848 (comment) under the following build:
Looks like everything is working as expected 👍 Going to start the uplift process for #4248. |
Submitter Checklist:
Resolves brave/brave-browser#6011
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Test case
Test case
Test case
Test case
Test case
Test case
Test case
server_publisher_amounts
table inpublisher_info_db
to change the value set in step 4 to another value. For example, if the publisher has defaults of [5, 10, 20], and you selected 5 BAT in step 4, change the value in the table from 5 to 6 BATReviewer Checklist:
After-merge Checklist:
changes has landed on.