-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable default tip amounts #6011
Comments
server implemented in brave-intl/bat-ledger#721 |
@mandar-brave based on the fact that we are splitting monthly contribution and tip flow, should we have two defaults? One set for monthly and one for tip? |
Yes; my understanding was that monthly a/c had a default that could be controlled by the server? |
@mandar-brave I am talking about monthly contributions not AC. @evq me and @mandar-brave discussed this via DM and could you please add monthly contribution default amounts as well. Flow will split on desktop so we need to have defaults separate. Thank you |
merged in brave-intl/bat-ledger#723 |
@evq @NejcZdovc is there anything that we should check on the server side of things? Or is running through brave/brave-core#3848 (comment) sufficient enough to call this verified? |
@kjozwiak nothing that I can think of |
Verification PASSED on
Verification passed on
Verification passed on
|
Make default tip values configurable via server.
a) one set of values for one-time contributions brave-intl/bat-ledger#721
b) another set of values for monthly recurring contributions brave-intl/bat-ledger#723
The text was updated successfully, but these errors were encountered: