Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable default tip amounts #6011

Closed
mandar-brave opened this issue Sep 13, 2019 · 8 comments · Fixed by brave/brave-core#3848
Closed

Configurable default tip amounts #6011

mandar-brave opened this issue Sep 13, 2019 · 8 comments · Fixed by brave/brave-core#3848

Comments

@mandar-brave
Copy link

mandar-brave commented Sep 13, 2019

Make default tip values configurable via server.
a) one set of values for one-time contributions brave-intl/bat-ledger#721
b) another set of values for monthly recurring contributions brave-intl/bat-ledger#723

@mandar-brave mandar-brave added feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Sep 13, 2019
@evq
Copy link
Member

evq commented Sep 14, 2019

server implemented in brave-intl/bat-ledger#721

@NejcZdovc
Copy link
Contributor

@mandar-brave based on the fact that we are splitting monthly contribution and tip flow, should we have two defaults? One set for monthly and one for tip?

@mandar-brave
Copy link
Author

Yes; my understanding was that monthly a/c had a default that could be controlled by the server?

@NejcZdovc
Copy link
Contributor

@mandar-brave I am talking about monthly contributions not AC. @evq me and @mandar-brave discussed this via DM and could you please add monthly contribution default amounts as well. Flow will split on desktop so we need to have defaults separate. Thank you

@evq
Copy link
Member

evq commented Sep 22, 2019

merged in brave-intl/bat-ledger#723

@kjozwiak
Copy link
Member

@evq @NejcZdovc is there anything that we should check on the server side of things? Or is running through brave/brave-core#3848 (comment) sufficient enough to call this verified?

@NejcZdovc
Copy link
Contributor

@kjozwiak nothing that I can think of

@kjozwiak
Copy link
Member

kjozwiak commented Jan 16, 2020

Verification PASSED on macOS 10.15.2 x64 using the following build:

Brave 1.3.91 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS macOS Version 10.15.2 (Build 19C57)

Verification passed on

Brave 1.3.92 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verification passed on

Brave 1.3.92 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS Ubuntu 18.04 LTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants