Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set wildcard last so content settings observer picks up the right value (uplift to 0.70.x) #3706

Merged
merged 1 commit into from
Oct 16, 2019
Merged

set wildcard last so content settings observer picks up the right value (uplift to 0.70.x) #3706

merged 1 commit into from
Oct 16, 2019

Conversation

bridiver
Copy link
Collaborator

@bridiver bridiver commented Oct 15, 2019 •
edited by bsclifton
Loading

Uplift of #3694 (squashed) to beta
Fixes brave/brave-browser#6389

@bridiver bridiver requested a review from iefremov as a code owner October 15, 2019 18:40
@bsclifton bsclifton requested a review from a team October 15, 2019 18:41
@bsclifton bsclifton changed the title set wildcard last so content settings observer picks up the right value set wildcard last so content settings observer picks up the right value (uplift to 0.70.x) Oct 15, 2019
@bsclifton bsclifton removed the request for review from iefremov October 15, 2019 18:41
@bsclifton bsclifton added this to the 0.70.x - Beta milestone Oct 15, 2019
kjozwiak
kjozwiak approved these changes Oct 16, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.70.x approved after deliberating with @brave/uplift-approvers. Both CI/Jenkins and CI/Travis passed without any issues. Please make sure the all the correct labels are being used and the associated issue is moved into the correct milestone.

@bsclifton bsclifton merged commit 8745852 into 0.70.x Oct 16, 2019
@bsclifton bsclifton deleted the pr3694_issues/6389_0.70.x branch October 16, 2019 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@bridiver bridiver

Labels
None yet
Projects
None yet
Milestone
0.70.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@bridiver @kjozwiak @bsclifton