Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set wildcard last so content settings observer picks up the right value #3694

Merged
merged 1 commit into from
Oct 15, 2019

Conversation

bridiver
Copy link
Collaborator

@bridiver bridiver commented Oct 14, 2019

fix brave/brave-browser#6389

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@bridiver bridiver requested a review from iefremov October 14, 2019 23:09
@bridiver bridiver self-assigned this Oct 14, 2019
@bridiver bridiver requested review from bbondy and bsclifton October 14, 2019 23:10
iefremov
iefremov previously approved these changes Oct 15, 2019
@iefremov
Copy link
Contributor

Looks good! Tested manually, seems fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

global shields setting for blocking all cookies isn’t being applied
2 participants