Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add don't ask again to translate bubble (uplift to 0.69.x) #3623

Merged
merged 1 commit into from
Oct 8, 2019
Merged

Add don't ask again to translate bubble (uplift to 0.69.x) #3623

merged 1 commit into from
Oct 8, 2019

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Oct 8, 2019 •
edited by bsclifton
Loading

Uplift of #3617

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly. (Tested on a local build.)
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@yrliou
Merge pull request #3617 from brave/translate_dont_ask_again
5c285cd 
Add don't ask again to translate bubble
@yrliou yrliou added this to the 0.69.x - next release milestone Oct 8, 2019
@yrliou yrliou requested a review from a team October 8, 2019 00:54
@yrliou yrliou self-assigned this Oct 8, 2019
bsclifton
bsclifton approved these changes Oct 8, 2019
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit af61eb1 into 0.69.x Oct 8, 2019
@bsclifton bsclifton deleted the translate_dont_ask_again_0.69.x branch October 8, 2019 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

Assignees

@yrliou yrliou

Labels
None yet
Projects
None yet
Milestone
0.69.x - Release Hotfix 1
Development

Successfully merging this pull request may close these issues.
2 participants
@yrliou @bsclifton