Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add don't ask again to translate bubble #3617

Merged
merged 1 commit into from
Oct 8, 2019
Merged

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Oct 7, 2019

Fix brave/brave-browser#6340
Screen Shot 2019-10-07 at 2 25 08 PM
Screen Shot 2019-10-07 at 2 24 59 PM

Submitter Checklist:

Test Plan:

  1. Open a browser
  2. Go to the language dropdown in brave://settings/languages and make sure Offer to translate pages that aren't in a language you read is enabled.
  3. Open a new tab and visit https://www.deutschland.de/de
  4. When translate bubble is shown, click don't ask me again.
  5. Go back to the settings tab, the switch in step 2 should now show as disabled.
  6. Refresh the https://www.deutschland.de/de tab, no translate bubble should be shown.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@yrliou yrliou added this to the 0.72.x - Nightly milestone Oct 7, 2019
@yrliou yrliou self-assigned this Oct 7, 2019
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Works as expected.

@yrliou yrliou merged commit 9c448c7 into master Oct 8, 2019
@yrliou yrliou deleted the translate_dont_ask_again branch October 8, 2019 00:29
brave-builds pushed a commit that referenced this pull request Oct 8, 2019
brave-builds pushed a commit that referenced this pull request Oct 8, 2019
yrliou added a commit that referenced this pull request Oct 8, 2019
Add don't ask again to translate bubble
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding "Never Ask Again" under Google Translate popup
2 participants