Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds random delay between transactions (uplift to 0.69.x) #3543

Merged
merged 2 commits into from
Sep 27, 2019
Merged

Adds random delay between transactions (uplift to 0.69.x) #3543

merged 2 commits into from
Sep 27, 2019

Conversation

NejcZdovc
Copy link
Contributor

Uplift of #3388

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@NejcZdovc NejcZdovc added this to the 0.69.x - Release milestone Sep 26, 2019
@NejcZdovc NejcZdovc requested a review from a team September 26, 2019 18:18
@NejcZdovc NejcZdovc self-assigned this Sep 26, 2019
@NejcZdovc NejcZdovc removed the request for review from kylehickinson September 26, 2019 18:18
kylehickinson
kylehickinson approved these changes Sep 26, 2019
View reviewed changes
Copy link
Collaborator

@kylehickinson kylehickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iOS changes are good

@NejcZdovc
Copy link
Contributor Author

CI failures not related to this PR

@kjozwiak
Copy link
Member

Restarting the PR as npm run network-audit -- --output_path="src/out/Release/brave" failed via https://staging.ci.brave.com/job/brave-browser-build-pr/job/pr3388_transfer-fee_0.70.x/1/execution/node/378/log/. This is an intermittent issue that's not related to the handlebars issue.

@kjozwiak
Copy link
Member

Looks like the only failures are due to the handlebars package failing npm run audit_deps which is a known issue and not related to this particular PR 👍

@kjozwiak kjozwiak mentioned this pull request Sep 27, 2019
Closed
kjozwiak
kjozwiak approved these changes Sep 27, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.69.x approved after deliberating with @brave/uplift-approvers. Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@NejcZdovc NejcZdovc merged commit cb0b6a2 into 0.69.x Sep 27, 2019
@bsclifton bsclifton deleted the transfer-fee-69 branch October 8, 2019 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@kylehickinson kylehickinson kylehickinson approved these changes

Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards
Projects
None yet
Milestone
0.69.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@NejcZdovc @kjozwiak @kylehickinson