Include a random delay between sending fee and tips for p2p contributions

[evq]

Description

Once the publishers API parts of https://github.com/brave-intl/creators-private-issues/issues/623 are rolled out we should add a random delay between sending the fee and tip

[GeetaSarvadnya]

@NejcZdovc Can you please include the test plan?

[NejcZdovc]

@GeetaSarvadnya added

[GeetaSarvadnya]

@NejcZdovc Verified the test plan from brave/brave-core#3388. After tipping a verified pub in staging env there's just 3 to 4 secs of delay to reflect the 5% fee in the brave card. The delay is not Noticeable (by the time I navigate from brave://rewards to ledgers sandbox tab 3 secs will over) step 3 in the test plan says to wait until 5% fee card reflect. Is 3 to 4 sec is the expected delay?

5% fee card before tipping a verified

5% fee card after tipping a verified pub

[NejcZdovc]

delay is random, so yeah could be 4sec as well

[GeetaSarvadnya]

Verification passed on

Brave	0.69.128 Chromium: 77.0.3865.75 (Official Build) (64-bit)
Revision	201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

• Verified the test plan from Adds random delay between transactions brave-core#3388
• Include a random delay between sending fee and tips for p2p contributions #5334 (comment)

[kjozwiak]

@NejcZdovc did this land in 0.69.x? I'm just about to start the approval process for brave/brave-core#3543 which has yet to uplifted so assuming the above verification for window is invalid and needs to be rechecked once brave/brave-core#3543 lands. Clearing QA Pass-Win64.

@NejcZdovc please let me know if I'm wrong or have missed something 👍

[LaurenWags]

Verified passed with

Brave	0.69.130 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision	58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS	macOS Version 10.13.6 (Build 17G5019)

• Verified test plan from Adds random delay between transactions brave-core#3388 using staging env
• Verified 95% was sent first, and remaining 5% was sent with a delay instead of simultaneously as before
• Verified the 5% was displayed in the staging card as expected

Verification passed on

Brave	0.69.130 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision	58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

• Verified test plan from Adds random delay between transactions brave-core#3388 using staging env
• Verified 95% was sent first, and the remaining 5% was sent with a delay instead of simultaneously as before
• Verified the 5% was displayed in the staging card as expected

Verification passed on

Brave	0.69.130 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision	58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS	Ubuntu 18.04 LTS

• Verified test plan from Adds random delay between transactions brave-core#3388 using staging env
• Verified 95% was sent first, and the remaining 5% was sent with a delay instead of simultaneously as before
• Verified the 5% was displayed in the staging card as expected