Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override menu item colors on old macOS (uplift to 0.69.x) #3317

Merged
merged 1 commit into from
Sep 3, 2019
Merged

Override menu item colors on old macOS (uplift to 0.69.x) #3317

merged 1 commit into from
Sep 3, 2019

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Aug 30, 2019 •
edited by bsclifton
Loading

Uplift of #3266
Fixes brave/brave-browser#5423

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Aug 30, 2019
@brave-builds brave-builds added this to the 0.69.x - Beta milestone Aug 30, 2019
@bsclifton bsclifton requested review from a team and removed request for bridiver, bbondy, kjozwiak, bsclifton, rebron and srirambv August 30, 2019 21:45
@simonhong simonhong self-assigned this Sep 2, 2019
kjozwiak
kjozwiak approved these changes Sep 3, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.69.x approved after deliberating with @brave/uplift-approvers. Both CI/Jenkins and CI/Travis passed without any errors or failures. Please make sure that all the correct labels are being used and the associated issue is moved into the correct milstone.

@bsclifton bsclifton merged commit ddabfa4 into 0.69.x Sep 3, 2019
@bsclifton bsclifton deleted the pr3266_menu_color_on_high_sierra_0.69.x branch September 3, 2019 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@simonhong simonhong

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
0.69.x-backup
Development

Successfully merging this pull request may close these issues.
5 participants
@brave-builds @kjozwiak @bsclifton @simonhong @brave-browser-releases