-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hamburger menu unreadable in dark mode on High Sierra (macOS) #5423
Comments
cc: @simonhong |
@LaurenWags yes, this is the regression of #4637 only light theme is used for webui and base native ui(such as menu dialog) regardless of brave theme type). |
@LaurenWags you'll need to verify this one as I'm on |
Verified passed with
|
Description
Hamburger menu is unreadable when using dark mode on macOS High Sierra. Probably related to the fix for #4637 as this appears to only affect 0.69.x and higher versions.
Originally reported via https://twitter.com/nyzrox_dnb/status/1155274197809160193?s=12
Steps to Reproduce
Actual result:
Menu is unreadable unless you hover over an item.
Expected result:
Menu should be dark, but readable, i.e. light text on dark background as it appears on Mojave:
Reproduces how often:
easily
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
@kjozwiak unable to reproduce on Mojave, Windows. @GeetaSarvadnya unable to reproduce on Windows 10.
cc @bradleyrichter @rebron
The text was updated successfully, but these errors were encountered: