Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes twitch for the panel #3295

Merged
merged 1 commit into from
Aug 29, 2019
Merged

Fixes twitch for the panel #3295

merged 1 commit into from
Aug 29, 2019

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Aug 29, 2019

Resolves brave/brave-browser#5549

Submitter Checklist:

Test Plan:

  • enable rewards
  • go to twitch
  • go to some channels and vods
  • on every page open the panel and make sure that correct publisher is displayed in there

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added this to the 0.71.x - Nightly milestone Aug 29, 2019
@NejcZdovc NejcZdovc self-assigned this Aug 29, 2019
emerick
emerick previously approved these changes Aug 29, 2019
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NejcZdovc NejcZdovc merged commit 1e0c483 into master Aug 29, 2019
@NejcZdovc NejcZdovc deleted the fix-twitch branch August 29, 2019 22:50
brave-builds pushed a commit that referenced this pull request Aug 30, 2019
brave-builds pushed a commit that referenced this pull request Aug 30, 2019
@LaurenWags
Copy link
Member

Verified test plan using

Brave 0.71.51 Chromium: 76.0.3809.132 (Official Build) nightly (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X

Panel for Verified Twitch Publisher:
Screen Shot 2019-08-30 at 3 24 06 PM

Panel for Connected, not verified Twitch Publisher:
Screen Shot 2019-08-30 at 3 24 18 PM

Panel for unverified Twitch Publisher:
Screen Shot 2019-08-30 at 3 24 49 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panel is broken for Twitch - unable to tip Twitch publishers
4 participants