Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verified logo not displaying until panel is opened for Twitch publishers #5848

Closed
LaurenWags opened this issue Aug 30, 2019 · 4 comments
Closed

Comments

@LaurenWags
Copy link
Member

Description

Follow up to #5549

When navigating to a verified or connected Twitch publisher page, the verified icon doesn't display on the BAT logo until you open the panel. If you navigate to another page and come back, the verified logo isn't displayed again (until you open the panel).

Steps to Reproduce

  1. Install 0.71.51 Nightly
  2. Enable Rewards
  3. Navigate to a verified Twitch publisher (if using staging, you can go to twitch.tv/laurenwags) or connected Twitch publisher (if using staging, you can go to twitch.tv/ilikeblueturtles)

Actual result:

Verified logo isn't displayed on the BAT icon until you open the panel.
Screen Shot 2019-08-30 at 3 34 30 PM

Screen Shot 2019-08-30 at 3 34 47 PM

Expected result:

Verified icon displayed on BAT logo without having to open panel first.
Screen Shot 2019-08-30 at 3 34 56 PM

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.71.51 Chromium: 76.0.3809.132 (Official Build) nightly (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the dev channel? n/a
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? yes
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

This doesn't happen for regular sites, YouTube, Vimeo, GitHub, or Reddit publishers.

@GeetaSarvadnya
Copy link

The issue is Reproducible in BraveNightly 0.72.3 staging environment - Until I open BR panel verified icon is not displayed on BAT logo in URL bar

image

@Miyayes
Copy link
Collaborator

Miyayes commented Jul 22, 2022

@LaurenWags @GeetaSarvadnya Is this still reproducible in recent versions of Brave as of July 2022?

@GeetaSarvadnya
Copy link

The issue is fixed and working fine on Windows 10 x64 - 1.42.86. The verified logo is displayded as soon as a twitch publisher is visited

Brave | 1.42.86 Chromium: 104.0.5112.81 (Official Build) (64-bit)
-- | --
Revision | 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS | Windows 10 Version 21H2 (Build 19044.1826)

Twitch pubs

@LaurenWags
Copy link
Member Author

Thanks @GeetaSarvadnya! Just added some labels and a milestone to this one 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants