-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow Shields to block urls with invalid origins #3210
Conversation
fix brave/brave-browser#5346 fix brave/brave-browser#5483 shields can't manually block urls with invalid origins, making blob:// and data:// scripts impossible to allow once, for example. this channge ensures that Shields see such scripts the same way as scripts with valid origins.
Manual tests work great - changes look good. I'm getting two browser test failures though:
Both fail every time; I'm running with: |
ah forgot to update them, will upload a fix momentary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran through manual test plan. Also verified all tests pass locally. Changes look good!
Let's wait for CI before merging, but I think we can uplift this change back to 0.69.x 😄
Great teamwork! 💯
CI is green, merged. |
fix brave/brave-browser#5346
fix brave/brave-browser#5483
shields can't manually block urls with invalid origins, making blob:// and data:// scripts impossible to allow once, for example.
Test Plan
See brave/brave-browser#5346 and brave/brave-browser#5483.
Reviewer Checklist:
After-merge Checklist:
changes has landed on.