allow Shields to block urls with invalid origins #3210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cezaraugusto
requested review from
simonhong and
bsclifton
and removed request for
yrliou
fix brave/brave-browser#5346 fix brave/brave-browser#5483 shields can't manually block urls with invalid origins, making blob:// and data:// scripts impossible to allow once, for example. this channge ensures that Shields see such scripts the same way as scripts with valid origins.
|
Manual tests work great - changes look good. I'm getting two browser test failures though: Both fail every time; I'm running with: |
|
ah forgot to update them, will upload a fix momentary. |
bsclifton
approved these changes
Aug 20, 2019
|
CI is green, merged. |
brave-builds
pushed a commit
that referenced
this pull request
Aug 20, 2019
This was referenced Aug 20, 2019
cezaraugusto
pushed a commit
that referenced
this pull request
Aug 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix brave/brave-browser#5346
fix brave/brave-browser#5483
shields can't manually block urls with invalid origins, making blob:// and data:// scripts impossible to allow once, for example.
Test Plan
See brave/brave-browser#5346 and brave/brave-browser#5483.
Reviewer Checklist:
After-merge Checklist:
changes has landed on.