Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shields menu not visible after allowing all scripts #5483

Closed
GeetaSarvadnya opened this issue Jul 31, 2019 · 3 comments · Fixed by brave/brave-core#3210
Closed

Shields menu not visible after allowing all scripts #5483

GeetaSarvadnya opened this issue Jul 31, 2019 · 3 comments · Fixed by brave/brave-core#3210
Assignees
@cezaraugusto
Labels
bug feature/shields/panel Front-end design and functionality of the Shields panel. priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
0.69.x - Release

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 31, 2019 •
edited
Loading

Description

Found while testing #4570

Shields menu not visible after allowing all scripts

Steps to Reproduce

STR1:

  1. Clean profile 0.68.114
  2. Open buzzfeed.com in a new tab
  3. Click on Shield
  4. Turn ON Scripts blocked option
  5. Click on Scripts blocked in the shield
  6. Click on Allow All in Blocked scripts
  7. Click on Allow All again in Blocked scripts
  8. Shields menu not visible after allowing all scripts

STR2:

  1. Clean profile 0.68.114
  2. Open buzzfeed.com in a new tab
  3. Click on shield panel
  4. Turn ON scripts
  5. Click on Cross-site trackers blocked
  6. Allow scripts once link is reflected in cross-site trackers list
  7. Click on Allow scripts once link multiple times which is reflected in cross-site trackers list
  8. Click on Scripts blocked in the shield
  9. Shield menu is NOT visible

Actual result:

Shields menu not visible after allowing all scripts

image

Recorded file:
https://drive.google.com/open?id=1D9c7nyl-N0iB4ULng47pLIahIrbG1HDw

Expected result:

Shields menu should be displayed after allowing all scripts

Reproduces how often:

Always

Brave version (brave://version info)

Brave 0.68.114 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Windows 10 OS Version 1803 (Build 17134.523)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @cezaraugusto @karenkliu @rebron
@GeetaSarvadnya GeetaSarvadnya added the priority/P1 A very extremely bad problem. We might push a hotfix for it. label Jul 31, 2019
@btlechowski btlechowski mentioned this issue Jul 31, 2019
Closed
@tildelowengrimm tildelowengrimm added feature/shields/panel Front-end design and functionality of the Shields panel. priority/P2 A bad problem. We might uplift this to the next planned release. and removed feature/shields/!scripts Blocking JavaScript with Shields priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Jul 31, 2019
@LaurenWags
Copy link
Member

Reproduced with macOS

Brave 0.68.118 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Mac OS X

@btlechowski
Copy link

Reproduced on Ubuntu

Brave 0.68.118 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Ubuntu 18.04 LTS

@cezaraugusto cezaraugusto mentioned this issue Aug 20, 2019
Merged
6 tasks
bsclifton pushed a commit to brave/brave-core that referenced this issue Aug 20, 2019
@cezaraugusto @bsclifton
allow Shields to block urls with invalid origins
50b8e6b 
fix brave/brave-browser#5346
fix brave/brave-browser#5483

shields can't manually block urls with invalid origins, making
blob:// and data:// scripts impossible to allow once, for example.
this channge ensures that Shields see such scripts the same way as
scripts with valid origins.
@yrliou yrliou added this to the 0.71.x - Nightly milestone Aug 20, 2019
This was referenced Aug 20, 2019
Merged
Merged
@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Sep 3, 2019 •
edited by LaurenWags
Loading

Verification passed on

Brave 0.69.121 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • Verified the STR from the description

Verification passed on

Brave 0.69.121 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Ubuntu 18.04 LTS
  • Verified the STR from the description

Verified passed with

Brave 0.69.124 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X
  • Verified the STR from the description

@kjozwiak kjozwiak mentioned this issue Oct 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
bug feature/shields/panel Front-end design and functionality of the Shields panel. priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
0.69.x - Release
Development

Successfully merging a pull request may close this issue.

allow Shields to block urls with invalid origins brave/brave-core
7 participants
@tildelowengrimm @cezaraugusto @yrliou @bsclifton @LaurenWags @btlechowski @GeetaSarvadnya