Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ NTP Widgetfication #3157

Merged
merged 3 commits into from
Aug 15, 2019
Merged

✨ NTP Widgetfication #3157

merged 3 commits into from
Aug 15, 2019

Conversation

imptrx
Copy link
Contributor

@imptrx imptrx commented Aug 12, 2019

Spec: brave/brave-browser#5015

Quick view:
ntp-widgets

Submitter Checklist:

Test Plan:

brave/brave-browser#5015 (comment)

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@imptrx imptrx requested a review from cezaraugusto August 12, 2019 23:15
@imptrx imptrx force-pushed the pxu-ntp-widgets branch 2 times, most recently from b706fc9 to 4c440cf Compare August 14, 2019 21:05
@imptrx imptrx marked this pull request as ready for review August 14, 2019 21:06
@imptrx imptrx changed the title 🚧 NTP Widgetfication ✨ NTP Widgetfication Aug 14, 2019
@imptrx imptrx self-assigned this Aug 14, 2019
@imptrx imptrx added this to the 0.71.x - Nightly milestone Aug 14, 2019
@imptrx imptrx force-pushed the pxu-ntp-widgets branch 2 times, most recently from bb4bf0e to b22c3c9 Compare August 14, 2019 21:17
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@cezaraugusto cezaraugusto merged commit 4b53c39 into master Aug 15, 2019
@imptrx imptrx deleted the pxu-ntp-widgets branch August 15, 2019 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants