Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget menu for new tabs page elements #5015

Closed
imptrx opened this issue Jun 22, 2019 · 7 comments
Closed

Widget menu for new tabs page elements #5015

imptrx opened this issue Jun 22, 2019 · 7 comments

Comments

@imptrx
Copy link

imptrx commented Jun 22, 2019

Description

Related issue: #4510
Currently showing and hiding widgets in NTP is available soon via the Dashboard Settings Menu. We should also be able to control these options via opening a "widget" menu that shows up via menu button or right clicking the widget.

Hover or tab over the Brave Stats widget to highlight it and display an icon representing menu options:

r1 toggle widgets - stats 1

Clicking/selecting the icon shows a menu with widget options:

r1 toggle widgets - stats 2

Hover or tab over the Clock widget to highlight it and display an icon representing menu options:

r1 toggle widgets - clock 1

Clicking/selecting the icon shows a menu with widget options:

r1 toggle widgets - clock 2

Hover or tab over the Top Sites widget to highlight it and display an icon representing menu options:

r1 toggle widgets - top sites 1

Clicking/selecting the icon shows a menu with widget options:

r1 toggle widgets - top sites 2

@imptrx imptrx self-assigned this Jun 22, 2019
@brave brave deleted a comment from yodaross Jun 25, 2019
@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Jun 27, 2019
@imptrx
Copy link
Author

imptrx commented Aug 12, 2019

Test Plan:
Widget Behaviour

  • Hover over widgets should produce a hover effect and an icon beside it
  • Clicking on the icon for each widget should open up a menu (clicking again will toggle)
  • If menu is open, moving the cursor away from the widget wouldn’t remove the hover effect
  • If menu is closed, moving the cursor away from the widget removed hover effects
  • If menu is open clicking outside the menu will close the menu and disable toggle
  • Clicking remove from each widget menu will remove the widget from the page
  • When re-enabling the widget(via the customization menu at the bottom right/left side of page) - widget menu should be closed, no hover effect

Icon placement on hover

  • On large screen, widget icon will appear towards the center of the page (away from edge)
  • On smaller screens, all widget icon will appear towards the right (or left depending on locale)

@GeetaSarvadnya
Copy link

Verification passed on

Brave 0.70.97 Chromium: 77.0.3865.65 (Official Build) beta (64-bit)
Revision 87a331a3169cab563505fb44011058b904011ba1-refs/branch-heads/3865@{#726}
OS Windows 10 OS Version 1803 (Build 17134.1006)

@btlechowski
Copy link

@kjozwiak This feature is not implemented in 0.69.128. It works well in 0.70.100.

@bsclifton
Copy link
Member

Moving milestones to 0.70.x
cc: @cezaraugusto

@kjozwiak
Copy link
Member

@bsclifton thanks for moving, was this supposed to be in 0.69.x? Just want to make sure we haven't missed anything important when we did the merge 👍 Maybe @cezaraugusto can comment with more context.

@rebron
Copy link
Collaborator

rebron commented Oct 1, 2019

@kjozwiak This issue didn't need to go into 0.69.x. Incremental fixes for new tab page are riding the trains so this fix in 0.70.x.

@LaurenWags
Copy link
Member

LaurenWags commented Oct 8, 2019

Verified passed with

Brave 0.70.110 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)

Screen Shot 2019-10-08 at 1 43 14 PM

Screen Shot 2019-10-08 at 1 43 23 PM

Screen Shot 2019-10-08 at 1 43 33 PM

  • Per test plan, for small screens, L->R languages (ex. English) menu widget is on Right and for R->L languages (ex. Hebrew) menu widget is on Left.

Screen Shot 2019-10-08 at 1 44 35 PM

Screen Shot 2019-10-08 at 1 48 01 אח׳

Verification passed on

Brave 0.70.109 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Ubuntu 18.04 LTS

High resolution
image
image
image
Low resolution
image
image
image
RTL High resolution
image
image
image
RTL Low resolution
image
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants